Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version, again #461

Closed
louisremi opened this issue Mar 1, 2017 · 4 comments
Closed

Wrong version, again #461

louisremi opened this issue Mar 1, 2017 · 4 comments

Comments

@louisremi
Copy link

I just downloaded linux-0.3.0 and installed it. When I run kompose version I get 0.2.0 (10cff91).
Also, I gave 0.3.0 a try because I had troubles with underscores in volume names, and after running kompose convert, the underscore were still present. I'll try compiling from source to confirm, but could it be possible that the published version does not include that patch?

@kadel
Copy link
Member

kadel commented Mar 1, 2017

Hi @louisremi,
You are right, we uploaded binary that is showing wrong version number in kompose version :-(
Binary is correct it is compiled from latest source (in time of the release).

Underscore problem got fixed in service names, but not in volume names :-(
We will fix that.
I've reopened #420

@kadel
Copy link
Member

kadel commented Mar 1, 2017

@cdrage we need to do something to make sure that we don't release binaries with wrong version again.

@cdrage
Copy link
Member

cdrage commented Mar 1, 2017

Yeah, this is totally my fault, I had forgotten to add a function from a previous project to this release script in regards to syncing with the master repo before upload / making of the binaries.

I've fixed this in #465

@kadel
Copy link
Member

kadel commented Apr 26, 2017

this has been fixed, shouldn't happen again :-)

@kadel kadel closed this as completed Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants