Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for: top-level volumes. #447

Closed
cdrage opened this issue Feb 23, 2017 · 14 comments
Closed

Support for: top-level volumes. #447

cdrage opened this issue Feb 23, 2017 · 14 comments
Labels
kind/discuss lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@cdrage
Copy link
Member

cdrage commented Feb 23, 2017

Using a top-level volume errors out and is unsupported:

version: "2"

services:
    redis:
      image: redis:3.0

volumes:
  - /var/lib/mysql
ERRO Could not parse config for project wikus : yaml: unmarshal errors:
  line 8: cannot unmarshal !!seq into map[string]interface {} 
FATA Failed to load compose file: yaml: unmarshal errors:
  line 8: cannot unmarshal !!seq into map[string]interface {} 
@cdrage
Copy link
Member Author

cdrage commented Jun 20, 2017

@surajnarwade @procrypt

Is it possible to investigate this to see what we could possibly do to implement it?

Of course, other top-level keys such as networks makes sense not to support, but volumes seems important.

@procrypt
Copy link

@cdrage Will look into it. @surajnarwade Do you have some time today we can discuss about it.

@surajnarwade
Copy link
Contributor

@procrypt sure

@surajnarwade
Copy link
Contributor

@cdrage , I think top-level volumes keys dont make any sense.

@cdrage
Copy link
Member Author

cdrage commented Jun 28, 2017

@surajnarwade Could you give your reasoning as to why they don't make sense?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2017
@cdrage
Copy link
Member Author

cdrage commented Jan 2, 2018

Ping @surajnarwade

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 7, 2018
@surajnarwade
Copy link
Contributor

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 8, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 9, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 8, 2018
@cdrage
Copy link
Member Author

cdrage commented Jun 8, 2018

Don't we support this now @hangyan ? I think we do..

@hangyan
Copy link
Contributor

hangyan commented Jun 10, 2018

@cdrage No, we haven't...

@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/discuss lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants