Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move functional tests to golang #432

Closed
concaf opened this issue Feb 20, 2017 · 11 comments
Closed

move functional tests to golang #432

concaf opened this issue Feb 20, 2017 · 11 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P3

Comments

@concaf
Copy link
Contributor

concaf commented Feb 20, 2017

Hi,

Currently, currently all the functional tests being run by make test-cmd are written in shell scripts, which are very difficult to maintain, debug and produce a lot of false positives e.g. #431, etc.

Should we move these to golang for better testing?

(thinking out loud: how about python which has a rich set of testing libraries e.g. py.test)?

Thoughts?

@kadel
Copy link
Member

kadel commented Feb 20, 2017

👍 for writing them in go.

(thinking out loud: how about python which has a rich set of testing libraries e.g. py.test)?

I think it is better to avoid adding new language with additional dependencies, even if it is just for testing.

@procrypt
Copy link

procrypt commented Mar 7, 2017

@containscafeine @kadel I'm taking this up.

@surajssd
Copy link
Member

surajssd commented Mar 8, 2017

I am 👍 for Python but it's just that people should know one more language for doing any contribution.

But if you know Python it will be very easier.

@kadel
Copy link
Member

kadel commented Mar 8, 2017

Please no Python, no other language.
I would rather stick with bash rather than introducing another language.

@concaf
Copy link
Contributor Author

concaf commented Mar 8, 2017

Ack, let's move all of 'em to golang 🤘

@surajssd
Copy link
Member

maybe we can look at this framework https://github.com/DATA-DOG/godog it is for doing golang functional testing.

@procrypt
Copy link

@surajssd Do we really need to use a Framework for it, I mean we are just comparing the output.

@surajssd
Copy link
Member

@procrypt not really if we can achieve what we do now without any framework then it's good.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 21, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P3
Projects
None yet
Development

No branches or pull requests

6 participants