Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests before merge #349

Closed
surajssd opened this issue Dec 27, 2016 · 2 comments
Closed

Tests before merge #349

surajssd opened this issue Dec 27, 2016 · 2 comments
Labels
kind/testing

Comments

@surajssd
Copy link
Member

After a maintainer does merge, tests should run with PR rebased with master, and if all tests pass then only merge should happen. I think this can be implemented with travis.
@cdrage
Copy link
Member

cdrage commented Jun 26, 2017

@surajssd I've gone ahead and enabled this within GitHub. Tests are now required to pass before merging in (can't merge in without travis being 💚 )

@cdrage cdrage closed this as completed Jun 26, 2017
@surajssd
Copy link
Member Author

@cdrage awesome thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@surajssd @cdrage