Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kompose convert panic on v1 compose file #102

Closed
janetkuo opened this issue Aug 12, 2016 · 4 comments
Closed

kompose convert panic on v1 compose file #102

janetkuo opened this issue Aug 12, 2016 · 4 comments

Comments

@janetkuo
Copy link
Member

janetkuo commented Aug 12, 2016

Converting examples/docker-compose.yml to k8s...

$ kompose convert 
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x8 pc=0x46be8a]

It's because of this line which references Networks (which is nil, since it's v1 compose file):

//FIXME: networks always contains one default element, even it isn't declared in compose v2.
if len(composeServiceConfig.Networks.Networks) > 0 &&

@surajssd we need to add those example files to the test

@janetkuo
Copy link
Member Author

Fixing in #103, still need tests

@ngtuna
Copy link
Contributor

ngtuna commented Aug 12, 2016

Super @janetkuo . I saw this panic error last night but immediately had to go to sleep so didn't fix.Thanks for your quick react 👍

@ngtuna
Copy link
Contributor

ngtuna commented Aug 12, 2016

This issue also stopped me to finish my PR #91.

@janetkuo
Copy link
Member Author

This is fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants