chart: allow setting allocateLoadBalancerNodePorts

[tamcore]

What this PR does / why we need it:

This change adds an optional allocateLoadBalancerNodePorts parameter to both controller services. Kubernetes sets it to true by default, which unnecessarily opens nodePorts, which, depending on the used LoadBalancer implementation (MetalLB for example) are not needed.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

fixes #10440

How Has This Been Tested?

• helm template

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	3a5d8be
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/654400e61ac7f40008b96e4c

[k8s-ci-robot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @tamcore. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rikatz]

/ok-to-test
Please make sure to also run helm docs

[rikatz]

/approve

Leaving a pre-approval here, once the comment is fixed I can lgtm

[tamcore]

@rikatz updated the comment and added a link to the official documentation as well. But helm-docs doesn't produce any changes. Most likely because the parameter is left commented.

[rikatz]

/lgtm
Thanks

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, tamcore

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[strongjz]

/cherry-pick release-1.9

[k8s-infra-cherrypick-robot]

@strongjz: new pull request created: #10693

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.