-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OpenTelemetry Module #11496
Comments
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @esigo |
For what it's worth, with the current helm chart version 4.11.0 I seem to end up with two variants of the
My impression from looking around the code was that the |
@esigo do you have any plans to update the module, or are you considering other options? The updated module includes a change required so that calculating error rate metrics for application performance monitoring. With Ingress-NGINX versions before 1.10.0 this was possible when using OpenTracing. |
Duplicates of #11629. I strongly suggest to read all comments. TL;DR: A new release of the otel_ngx_module is required. |
Ingress-NGINX 1.10.0 has dropped support for OpenTracing and Zipkin, favoring OpenTelemetry instead. The OpenTelemetry module used by Ingress-NGINX is based on a commit from September 12, 2023, and has received updates since then.
Could you please update the module to a more recent version?
The commit I am interested in enhances the module by setting the span status to error when an HTTP request returns a 5xx status code, following the OpenTelemetry specification similar to the previously supported OpenTracing module.
The text was updated successfully, but these errors were encountered: