GLBC ingress: only handle annotated ingress

[bowei]

From @tamalsaha on December 14, 2016 21:49

Hi,
We are running a HAProxy based ingress in our clusters. But for a few service, we would like to run GLBC ingress. I did not see any way to tell ingress controllers, which Ingress resource they can handle. Can Ingress controllers can only handle ingress that has a specific annotation applied to it (similar to how schedulers do it):

"ingress.alpha.kubernetes.io/controller": glbc

Here is a way I could see being implemented. Glbc controller adds a new flag --ingress-controller.

If --ingress-controller flag value is empty, then glbc should handle any Ingress that has no annotation "ingress.alpha.kubernetes.io/controller" or annotation set to "" string.

If --ingress-controller flag is not empty, then only handle Ingress that has
"ingress.alpha.kubernetes.io/controller" : "".

Thanks.

Copied from original issue: kubernetes/ingress-nginx#59

[bowei]

From @bprashanth on December 16, 2016 0:45

such an annotation already exists ("kubernetes.io/ingress.class"), or maybe I'm confused?
https://github.com/kubernetes/contrib/blob/master/ingress/controllers/gce/BETA_LIMITATIONS.md#disabling-glbc
https://github.com/kubernetes/contrib/tree/master/ingress/controllers/nginx#running-on-cloudproviders

[bowei]

From @tamalsaha on December 16, 2016 8:7

@bprashanth , thanks for the link. I somehow missed the documentation on kubernetes.io/ingress.class. But I would still like a flag for both ingress controllers to disable default on mode. If that flag is set, then ingress controller's will not manage Ingress with kubernetes.io/ingress.class set to empty string.

[bowei]

From @bprashanth on December 16, 2016 17:38

Yeah that makes sense, I'm guessing you mean --ingress-class=gce only handles ingresses with kubernetes.io/ingress.class=gce. Please send a pr if you have time.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close