Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensible configuration/invocation of kubeadm #356

Closed
luxas opened this issue Jul 26, 2017 · 25 comments
Closed

Extensible configuration/invocation of kubeadm #356

luxas opened this issue Jul 26, 2017 · 25 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@luxas
Copy link
Member

luxas commented Jul 26, 2017

Feature Description

  • One-line feature description (can be used as a release note): kubeadm will have a new kubeadm phase command that supports performing only subtasks of the full kubeadm init flow. Combined with fine-grained configuration kubeadm will be easily consumable by higher-level tools like kops or GKE.
  • Primary contact (assignee): @luxas @justinsb
  • Responsible SIGs: @kubernetes/sig-cluster-lifecycle-feature-requests
  • Design proposal link (community repo): https://github.com/kubernetes/kubeadm/blob/master/docs/design/design_v1.8.md
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @timothysc @mikedanese
  • Approver (likely from SIG/area to which feature belongs): @jbeda @mikedanese
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y): v1.6
    • Beta release target (x.y): v1.12
    • Stable release target (x.y): TBD
@luxas luxas added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jul 26, 2017
@luxas luxas added this to the 1.8 milestone Jul 26, 2017
@luxas
Copy link
Member Author

luxas commented Sep 1, 2017

This will stay in alpha for one more release, but has seen significant improvement since v1.7
It is next to beta-level quality, but we still want to collect a little bit more feedback before graduating it.

@luxas luxas added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Sep 1, 2017
@idvoretskyi
Copy link
Member

@luxas @justinsb @kubernetes/sig-cluster-lifecycle-feature-requests can you confirm that this feature targets 1.8?

If yes, please, update the features tracking spreadsheet with the feature data, otherwise, let's remove this item from 1.8 milestone.

Thanks

@idvoretskyi idvoretskyi added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 18, 2017
@luxas
Copy link
Member Author

luxas commented Sep 20, 2017

@idvoretskyi This is targeting v1.8 indeed.
Added this to the feature spreadsheet as well

@luxas luxas removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 20, 2017
@luxas
Copy link
Member Author

luxas commented Oct 27, 2017

This will probably stay in alpha in v1.9 as it depends somewhat on the Cluster API work and different ComponentConfig implements from other SIGs

@luxas luxas modified the milestones: 1.8, 1.9 Oct 27, 2017
@zacharysarah
Copy link
Contributor

@luxas 👋 Please indicate in the 1.9 feature tracking board
whether this feature needs documentation. If yes, please open a PR and add a link to the tracking spreadsheet. Thanks in advance!

@luxas
Copy link
Member Author

luxas commented Nov 24, 2017

Docs PR: kubernetes/website#6103

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 24, 2018
@justaugustus
Copy link
Member

@luxas
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@luxas
Copy link
Member Author

luxas commented May 11, 2018

@justaugustus incremental progress will be made, but not targeting beta yet.

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label May 11, 2018
@luxas luxas removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 11, 2018
@luxas luxas removed this from the v1.9 milestone May 16, 2018
@luxas luxas added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jul 30, 2018
@luxas luxas modified the milestones: v1.11, v1.12 Jul 30, 2018
@luxas
Copy link
Member Author

luxas commented Jul 30, 2018

We're hoping to graduate this to beta in v1.12

@kacole2
Copy link

kacole2 commented Jul 30, 2018

@justaugustus can you add the tracked label here, please?

@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 30, 2018
@justaugustus
Copy link
Member

Done. Thanks for the updates, @luxas!

@justaugustus
Copy link
Member

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 31, 2018
@zparnold
Copy link
Member

Hey there! @luxas I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@justaugustus
Copy link
Member

@luxas @justinsb @timothysc --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@neolit123
Copy link
Member

so the kubeadm commands that this feature covers, remain under kubeadm alpha phase, because we didn't have the time to move them, but they are in a beta state.

in terms of documentation the commands are are already well covered in multiple k/website pages:
https://kubernetes.io/docs/reference/setup-tools/kubeadm/implementation-details/
https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-alpha/
https://kubernetes.io/docs/setup/independent/setup-ha-etcd-with-kubeadm/

i'm on the fence here given the remaining alpha tag, but i'm leaning towards 👍 for beta on this one for 1.12.

@tpepper
Copy link
Member

tpepper commented Sep 6, 2018

Would there be a commit to remove alpha in that command then?

@neolit123
Copy link
Member

neolit123 commented Sep 6, 2018

@tpepper it's too late for 1.12 as such a PR would have the kind/feature
we have this planned for 1.13:
kubernetes/kubeadm#454

@timothysc timothysc modified the milestones: v1.12, v1.13 Sep 7, 2018
@justaugustus justaugustus removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 7, 2018
@justaugustus
Copy link
Member

Thanks for the update, @neolit123!

@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 8, 2018
@timothysc
Copy link
Member

Our intention is to take kubeadm to GA in 1.13 which would include this item.

@spiffxp
Copy link
Member

spiffxp commented Oct 17, 2018

/stage stable
@kacole2 this should be bumped to stable in the spreadsheet

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Oct 17, 2018
@npentrel
Copy link

Hi @luxas, I'm Naomi working on docs for the 1.13 release. Can you please open a placeholder PR against dev-1.13 for this issue?

@timothysc
Copy link
Member

Closing in favor of #11 .

We are in the final stages now of moving towards GA.

@kacole2 kacole2 removed this from the v1.13 milestone Oct 30, 2018
@kacole2 kacole2 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests