Skip to content

Commit fbf2eda

Browse files
committed
node: topologymgr: Address SIG node reviewers' review comments
Signed-off-by: Swati Sehgal <[email protected]>
1 parent 2b861e2 commit fbf2eda

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

keps/sig-node/693-topology-manager/README.md

+9-3
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,6 @@ Device Manager and Device plugin node e2e tests:
683683
- N installs
684684
- More rigorous forms of testing.
685685
- Allowing time for user feedback.
686-
- Add support for device-specific topology constraints beyond NUMA.
687686
- Support hugepages alignment.
688687

689688
#### Deprecation
@@ -862,11 +861,18 @@ No.
862861

863862
###### Will enabling / using this feature result in increasing time taken by any operations covered by existing SLIs/SLOs?
864863

865-
No.
864+
Yes
865+
866+
This feature would impact the pod startup latency as it is measured from the time pod object is created and the resource alignment logic is executed
867+
at pod admission time. The check at admission is to determine if the pod is suitable to be admitted on the node based on the configured policy.
868+
If considered suitable, the pod is deemed suitable to be admitted on a node followed by the pod startup where resources are allocated to it based
869+
on the NUMA node identified suitable to allocate resource.
870+
Since Topology Manager supports a maximum of 8 NUMA nodes, pod startup latency has an upper bound for the additional latency introduced by the
871+
Topology Manager admission check.
866872

867873
This feature is not impacted by the scale of the cluster (number of nodes in the cluster) as that is not relevant and is not factored into the alignment algorithm. It is the scheduler that has to deal with the scalability aspect and determine nodes that can fulfill the resources requested by the pod. If this feature is turned off, the scheduler would still have to perform the same computation as it would if this feature was enabled. Hence, this feature is not impacted by scale or impacts the scalability of a cluster.
868874

869-
Also, the resource alignment logic is executed at pod admission time which is prior to pod startup so there shouldn't be any impact on pod startup latency. The check at admission is to determine if the pod is suitable to be admitted on the node based on the configured policy. If considered suitable, the pod proceeds to startup (following which the pod startup latency is measured).
875+
870876

871877
###### Will enabling / using this feature result in non-negligible increase of resource usage (CPU, RAM, disk, IO, ...) in any components?
872878

0 commit comments

Comments
 (0)