From 8b8abfcceec39a1738251706f0e8fa22741d8dee Mon Sep 17 00:00:00 2001 From: Sohan Kunkerkar Date: Fri, 19 Jan 2024 14:38:14 -0500 Subject: [PATCH] KEP-3983: target to beta for 1.30 Signed-off-by: Sohan Kunkerkar --- keps/sig-node/3983-drop-in-configuration/README.md | 8 ++++++-- keps/sig-node/3983-drop-in-configuration/kep.yaml | 6 +++--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/keps/sig-node/3983-drop-in-configuration/README.md b/keps/sig-node/3983-drop-in-configuration/README.md index 07edc5506d1..778684c8e3f 100644 --- a/keps/sig-node/3983-drop-in-configuration/README.md +++ b/keps/sig-node/3983-drop-in-configuration/README.md @@ -191,7 +191,7 @@ As a cluster admin, I would like to have cgroup management and log size manageme ##### e2e tests -* A test should confirm that the kubelet.conf.d directory is correctly processed, and its contents are accurately reported in the configz endpoint. +* A [test](https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/kubelet_config_dir_test.go) should confirm that the kubelet.conf.d directory is correctly processed, and its contents are accurately reported in the configz endpoint. ### Graduation Criteria @@ -295,12 +295,15 @@ In beta and onwards, the user will be able to read this off logs or the API, to ###### What are the reasonable SLOs (Service Level Objectives) for the enhancement? +The node bootstrap time should be minimal so kubelet doesn't take too long to reconcile the configuration. ###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service? +No noticeable increase in the kubelet startup time. ###### Are there any missing metrics that would be useful to have to improve observability of this feature? +No ### Dependencies @@ -370,7 +373,8 @@ Fix the invalid configuration, or remove configurations. - 2023-05-04: KEP initialized. - 2023-07-17: Alpha is implemented in 1.28 -- 2023-09-25: KEP targeted to Beta in 1.29 +- 2023-09-25: KEP retargeted to Alpha in 1.29 +- 2024-01-19: Added an [e2e](https://testgrid.k8s.io/sig-node-release-blocking#node-kubelet-serial-containerd&include-filter-by-regex=KubeletConfigDropInDir) test and set KEP target to Beta in 1.30 ## Drawbacks diff --git a/keps/sig-node/3983-drop-in-configuration/kep.yaml b/keps/sig-node/3983-drop-in-configuration/kep.yaml index 12300912ff3..a119e14ee08 100644 --- a/keps/sig-node/3983-drop-in-configuration/kep.yaml +++ b/keps/sig-node/3983-drop-in-configuration/kep.yaml @@ -7,7 +7,7 @@ authors: owning-sig: sig-node status: implementable creation-date: 2023-05-04 -last-updated: 2023-09-25 +last-updated: 2024-01-19 reviewers: - "@harche" approvers: @@ -19,12 +19,12 @@ stage: beta # The most recent milestone for which work toward delivery of this KEP has been # done. This can be the current (upcoming) milestone, if it is being actively # worked on. -latest-milestone: "v1.29" +latest-milestone: "v1.30" # The milestone at which this feature was, or is targeted to be, at each stage. milestone: alpha: "v1.28" - beta: "v1.29" + beta: "v1.30" stable: "v1.31" # The following PRR answers are required at alpha release