Skip to content

Commit 69dd916

Browse files
committed
Revert "Address key open items and move KEP to implementable state"
This reverts commit 29d95bc.
1 parent 29d95bc commit 69dd916

File tree

1 file changed

+2
-19
lines changed

1 file changed

+2
-19
lines changed

keps/sig-autoscaling/20181106-in-place-update-of-pod-resources.md

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ approvers:
2323
- "@mwielgus"
2424
editor: TBD
2525
creation-date: 2018-11-06
26-
last-updated: 2019-10-25
27-
status: implementable
26+
last-updated: 2018-11-06
27+
status: provisional
2828
see-also:
2929
replaces:
3030
superseded-by:
@@ -49,7 +49,6 @@ superseded-by:
4949
* [Scheduler and API Server interaction](#scheduler-and-api-server-interaction)
5050
* [Flow Control](#flow-control)
5151
* [Container resource limit update ordering](#container-resource-limit-update-ordering)
52-
* [Container resource limit update failure handling](#container-resource-limit-update-failure-handling)
5352
* [Notes](#notes)
5453
* [Affected Components](#affected-components)
5554
* [Future Enhancements](#future-enhancements)
@@ -168,12 +167,6 @@ Kubelet calls UpdateContainerResources CRI API which currently takes
168167
but not for Windows. This parameter changes to *runtimeapi.ContainerResources*,
169168
that is runtime agnostic, and will contain platform-specific information.
170169

171-
Additionally, GetContainerResources CRI API is introduced that allows Kubelet
172-
to query currently configured CPU and memory limits for a container.
173-
174-
These CRI changes are a separate effort that does not affect the design
175-
proposed in this KEP.
176-
177170
### Kubelet and API Server Interaction
178171

179172
When a new Pod is created, Scheduler is responsible for selecting a suitable
@@ -290,16 +283,6 @@ updates resource limit for the Pod and its Containers in the following manner:
290283
In all the above cases, Kubelet applies Container resource limit decreases
291284
before applying limit increases.
292285

293-
#### Container resource limit update failure handling
294-
295-
If multiple Containers in a Pod are being updated, and UpdateContainerResources
296-
CRI API fails for any of the containers, Kubelet will backoff and retry at a
297-
later time. Kubelet does not attempt to update limits for containers that are
298-
lined up for update after the failing container. This ensures that sum of the
299-
container limits does not exceed Pod-level cgroup limit at any point. Once all
300-
the container limits have been successfully updated, Kubelet updates the Pod's
301-
Status.ContainerStatuses[i].Resources to match the desired limit values.
302-
303286
#### Notes
304287

305288
* If CPU Manager policy for a Node is set to 'static', then only integral

0 commit comments

Comments
 (0)