Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow helm users to disable kong and use the ingress #9317

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mkhpalm
Copy link

@mkhpalm mkhpalm commented Jul 31, 2024

This change allows helm users to disable kong and enable the app.ingress without getting an error.

Fixes: #8972

https://kubernetes.io/docs/concepts/services-networking/ingress/#examples

Example values:

app:
  ingress:
    enabled: true
    hosts:
    - example.tld
kong:
  enabled: false

Copy link

linux-foundation-easycla bot commented Jul 31, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 31, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @mkhpalm!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkhpalm
Once this PR has been reviewed and has the lgtm label, please assign desaintmartin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 31, 2024
@floreks
Copy link
Member

floreks commented Aug 9, 2024

That's not something we'd want to support directly. The reason is that ingress has its limitations and can't support multiple backend protocols in a single ingress instance, i.e. gRPC and HTTP(s) (rest or gql). We know for sure that we will be migrating our backend architecture further and this configuration will eventually stop working. It would require multiple ingresses and that's not something we want to promote. That is why we want to use API Gateway which will handle everything and expose a single public-facing API.

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2024
@VergeDX
Copy link

VergeDX commented Sep 18, 2024

@floreks Consider using gateway api.
Also, If you want a background migrating, you can revert this commit anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingress not allowed when kong is disabled
4 participants