-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
LGTM. Out of curiosity, can this tag be used for |
It can, I'm not sure how I'm going to handle the 1.2 update. We don't really "release" cluster addons, the l7 controller runs on the master so it should just rev forward automatically on hosted offerings. If someone sets up a new cluster (with old 1.2 code) on gce/prem etc, they'll get an old l7. They can use kubectl edit to update the image on this old controller forward to 0.7.0. It should be safe to just update this tag to 1.2 because the resource didn't change, but I need to test it some more. |
I meant we don't branch, we release eg: https://github.com/kubernetes/contrib/releases, no reason we can't other than it's in beta so it's still in contrib/ |
We're about to cut a 1.2.5. If you get the PR into master for bumping |
Does this Travis ever work? |
(Feel free to merge if not.) |
Yeah I think it broke maybe because of some change, looking. Thanks for lgtm will merge when i fix. I think we wouldn't have the famed "green badge" if it didn't work: https://github.com/kubernetes/contrib |
Green, merging |
@aledbf fyi