Merge pull request #132276 from michaelasp/warningemu

Add warnings for use of Alpha features with Emulated Version

Kubernetes-commit: 06b62dcae7b2e11dbfc4aea2e0b8d5ced2cf26d9

Author: k8s-publishing-bot

compatibility/registry.go

@@ -400,13 +400,32 @@ func (r *componentGlobalsRegistry) Validate() []error {
 	defer r.mutex.Unlock()
 	for _, globals := range r.componentGlobals {
 		errs = append(errs, globals.effectiveVersion.Validate()...)
+		var features map[featuregate.Feature]featuregate.FeatureSpec
 		if globals.featureGate != nil {
 			errs = append(errs, globals.featureGate.Validate()...)
+			features = globals.featureGate.GetAll()
+		}
+		binaryVersion := globals.effectiveVersion.BinaryVersion()
+		emulatedVersion := globals.effectiveVersion.EmulationVersion()
+		if binaryVersion.GreaterThan(emulatedVersion) {
+			if enabled := enabledAlphaFeatures(features, globals); len(enabled) != 0 {
+				klog.Warningf("component has alpha features enabled in emulated version, this is unsupported: features=%v", enabled)
+			}
 		}
 	}
 	return errs
 }
 
+func enabledAlphaFeatures(features map[featuregate.Feature]featuregate.FeatureSpec, globals *ComponentGlobals) []string {
+	var enabled []string
+	for feat, featSpec := range features {
+		if featSpec.PreRelease == featuregate.Alpha && globals.featureGate.Enabled(feat) {
+			enabled = append(enabled, string(feat))
+		}
+	}
+	return enabled
+}
+
 func (r *componentGlobalsRegistry) SetEmulationVersionMapping(fromComponent, toComponent string, f VersionMapping) error {
 	if f == nil {
 		return nil

compatibility/registry_test.go

@@ -18,11 +18,11 @@ package compatibility
 
 import (
 	"fmt"
+	"reflect"
 	"strings"
 	"testing"
 
 	"github.com/spf13/pflag"
-
 	utilruntime "k8s.io/apimachinery/pkg/util/runtime"
 	"k8s.io/apimachinery/pkg/util/version"
 	"k8s.io/component-base/featuregate"
@@ -476,3 +476,45 @@ func assertVersionEqualTo(t *testing.T, ver *version.Version, expectedVer string
 	}
 	t.Errorf("expected: %s, got %s", expectedVer, ver.String())
 }
+
+func Test_enabledAlphaFeatures(t *testing.T) {
+	features := map[featuregate.Feature]featuregate.FeatureSpec{
+		"myFeat": {
+			PreRelease: featuregate.Alpha,
+		},
+		"myOtherFeat": {
+			PreRelease: featuregate.Beta,
+		},
+		"otherFeatDisabled": {
+			PreRelease: featuregate.Alpha,
+		},
+	}
+
+	alphaGate := featuregate.NewFeatureGate()
+	if err := alphaGate.Add(features); err != nil {
+		t.Fatalf("Unable to add features, %s", err)
+	}
+
+	err := alphaGate.SetFromMap(
+		map[string]bool{
+			"myFeat":            true,
+			"myOtherFeat":       true,
+			"otherFeatDisabled": false,
+		},
+	)
+	if err != nil {
+		t.Fatalf("Unable to set feature gate, %s", err)
+	}
+
+	globals := &ComponentGlobals{
+		featureGate: alphaGate,
+	}
+
+	want := []string{
+		"myFeat",
+	}
+
+	if got := enabledAlphaFeatures(features, globals); !reflect.DeepEqual(got, want) {
+		t.Errorf("enabledAlphaFeatures() = %v, want %v", got, want)
+	}
+}