[cinder-csi-plugin] Switch CSI sidecar image repository to gcr

[ialidzhikov]

What this PR does / why we need it:
Ref kubernetes-csi/csi-release-tools#86

Release note:

[cinder-csi-plugin] Use GCR images for CSI sidecar containers.

[k8s-ci-robot]

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ialidzhikov]

/cc @jichenjc @ramineni

[theopenlab-ci]

Build succeeded.

• cloud-provider-openstack-format : SUCCESS in 3m 26s

[theopenlab-ci]

Build succeeded.

• cloud-provider-openstack-unittest : SUCCESS in 3m 49s

[theopenlab-ci]

Build succeeded.

• cloud-provider-openstack-acceptance-test-csi-cinder : SUCCESS in 11m 50s

[theopenlab-ci]

Build succeeded.

• cloud-provider-openstack-e2e-test-csi-cinder : SUCCESS in 17m 06s

[theopenlab-ci]

Build succeeded.

• cloud-provider-openstack-multinode-csi-migration-test : SUCCESS in 43m 37s

[jichenjc]

/ok-to-test

[gouthampacha]

Hi @ialidzhikov - We've two CSI drivers in this repository, manila-csi being the other one [1][2]; so this change could update both of them at the same time. However, just to be sure - will the CSI container images no longer get published to quay.io? Or is this a temporary change?

[1] https://github.com/kubernetes/cloud-provider-openstack/tree/master/charts/manila-csi-plugin
[2] https://github.com/kubernetes/cloud-provider-openstack/tree/master/manifests/manila-csi-plugin

[ialidzhikov]

We've two CSI drivers in this repository, manila-csi being the other one [1][2]; so this change could update both of them at the same time

Currently one of the sidecar images for manilla-csi (I think it was the external-provisioner image) is outdated and this version is only available in quay. If you don't have objections I can file a separate PR for manilla-csi as I will need also to update the version of the sidecar container.

However, just to be sure - will the CSI container images no longer get published to quay.io? Or is this a temporary change?

As stated in kubernetes-csi/csi-release-tools#86 (comment), my understanding is that the push to quay will be dropped at some point in the time. For now I see that the recent images are also pushed to quay (probably for backwards compatibility reasons) but I think that soon the sidecar images will be maintained only in gcr. You can also see that the advertised images in the README.mds or in the releases are the gcr ones. @msau42 , @pohly feel free to add more details or correct me if I am wrong. : )

[gouthampacha]

We've two CSI drivers in this repository, manila-csi being the other one [1][2]; so this change could update both of them at the same time

Currently one of the sidecar images for manilla-csi (I think it was the external-provisioner image) is outdated and this version is only available in quay. If you don't have objections I can file a separate PR for manilla-csi as I will need also to update the version of the sidecar container.

That would be great - I've no objections. Thank you for submitting this change, @ialidzhikov

/cc @gman0 @tombarron

[jichenjc]

this works

# docker pull k8s.gcr.io/sig-storage/csi-provisioner:v1.6.1
v1.6.1: Pulling from sig-storage/csi-provisioner
Digest: sha256:3b9b5ae677fd74de3b1cde5d3606a970f615b598730aa003c0f52e755c78862e
Status: Downloaded newer image for k8s.gcr.io/sig-storage/csi-provisioner:v1.6.1
k8s.gcr.io/sig-storage/csi-provisioner:v1.6.1

[jichenjc]

just curious , should we update the release notes about the image modification ? @ialidzhikov

[ialidzhikov]

just curious , should we update the release notes about the image modification ? @ialidzhikov

I added a release note.

[ramineni]

Thanks.
/lgtm

[jichenjc]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jichenjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment