-
Notifications
You must be signed in to change notification settings - Fork 199
Added logic to start profiling service #3369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added logic to start profiling service #3369
Conversation
|
Hi @kolluria. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
792a266 to
10b29cc
Compare
10b29cc to
69ad3c7
Compare
|
/ok-to-test |
divyenpatel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
divyenpatel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel, kolluria The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds profiling endpoints to the
vsphere-csi-controllerandvsphere-syncercontainers. These endpoints will be useful for collecting performance samples, especially when running in scaled environments, to help identify bottlenecks.vsphere-csi-controller: profiling server on port 9500vsphere-syncer: profiling server on port 9501In scaled environments, performance bottlenecks are harder to detect. Enabling profiling allows us to gather heap, CPU, and goroutine profiles during live workloads and improve debugging and optimization workflows.
Testing done:
Verified that the containers are up and running with the patch -
Verified that we're able to collect samples from the endpoints -
Verified that the samples can be analysed using pprof -
Special notes for your reviewer:
Profiling is exposed over HTTP endpoints (no auth by default), so consider implications for production use.
Release note: