use patch method instead when update finalizer to PV

[carlory]

See kubernetes-csi/external-provisioner#1155 (comment)

/cc @deepakkinni @xing-yang @msau42

Action required: Using patch to update finalizers. Any external-provisioner now needs permission rules to patch PersistentVolumes. Please update RBAC rules of your provisioner.

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[carlory]

/test pull-sig-storage-lib-external-provisioner-unit

[xing-yang]

/assign @jsafrane

[deepakkinni]

capture and return results instead of directly making it a part of return. Something like:

pv, err := ctrl.client.CoreV1().PersistentVolumes().Patch(ctx, volume.Name, types.StrategicMergePatchType, patchBytes, metav1.PatchOptions{})
if err != nil {
 return nil, err
}
return pv

[carlory]

@deepakkinni done.

[carlory]

A flaking test on TestTopologyParams will be fixed by #165

[carlory]

I'm looking at another flaking test.

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_sig-storage-lib-external-provisioner/164/pull-sig-storage-lib-external-provisioner-unit/1768450559246864384

fatal error: concurrent map read and map write

It shouldn't relate to changes made by this PR. @deepakkinni

[carlory]

/test pull-sig-storage-lib-external-provisioner-unit

[xing-yang]

/lgtm

@jsafrane any concerns switching from update to patch?

[jsafrane]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsafrane]

/lgtm cancel

Please update examples/hostpath-provisioner/rbac.yaml with the new permissions.

[carlory]

@jsafrane added.

[jsafrane]

/lgtm