From cf83a9eb087ae696eeb9d4376e91c491a9a53bb0 Mon Sep 17 00:00:00 2001
From: Sascha Grunert <sgrunert@redhat.com>
Date: Tue, 14 Nov 2023 09:12:38 +0100
Subject: [PATCH] Disable e2e tests for now

Disable the vagrant based e2e tests until
https://github.com/actions/runner-images/issues/8730 is resolved.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
---
 .github/workflows/helm-chart-lint.yaml |  2 +-
 .github/workflows/test.yml             | 81 ++++++++++++++------------
 test/e2e_test.go                       | 11 ++--
 test/tc_base_profiles_oci_test.go      |  1 +
 4 files changed, 54 insertions(+), 41 deletions(-)

diff --git a/.github/workflows/helm-chart-lint.yaml b/.github/workflows/helm-chart-lint.yaml
index 55d939fe78..05cb4bec37 100644
--- a/.github/workflows/helm-chart-lint.yaml
+++ b/.github/workflows/helm-chart-lint.yaml
@@ -27,7 +27,7 @@ jobs:
           python-version: 3.7
 
       - name: Set up chart-testing
-        uses: helm/chart-testing-action@e8788873172cb653a90ca2e819d79d65a66d4e76 # v2.4.0
+        uses: helm/chart-testing-action@b43128a8b25298e1e7b043b78ea6613844e079b1 # v2.6.0
 
       - name: Run chart-testing (lint)
         run: >
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index ff40e7d318..c5bcf87bed 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -56,8 +56,10 @@ jobs:
           path: image.tar
 
   e2e-fedora:
+    # TODO(saschagrunert): re-enable when
+    # https://github.com/actions/runner-images/issues/8730 is resolved
+    if: false
     needs: image
-
     runs-on: macos-12
     timeout-minutes: 90
     env:
@@ -86,8 +88,10 @@ jobs:
           $RUN hack/ci/e2e-fedora.sh
 
   e2e-ubuntu:
+    # TODO(saschagrunert): re-enable when
+    # https://github.com/actions/runner-images/issues/8730 is resolved
+    if: false
     needs: image
-
     runs-on: macos-12
     timeout-minutes: 90
     env:
@@ -116,42 +120,47 @@ jobs:
           $RUN hack/ci/e2e-ubuntu.sh
 
   e2e-flatcar:
-   needs: image
-
-   runs-on: macos-12
-   timeout-minutes: 90
-   env:
-     RUN: ./hack/ci/run-flatcar.sh
-   steps:
-      - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v3.5.2
-      - name: Vagrant box version
-        id: vagrant-box
-        run: |
-          echo "version=$(curl -s  https://stable.release.flatcar-linux.net/amd64-usr/current/flatcar_production_vagrant.json | jq '.versions[0].version' | tr -d '".')" >> $GITHUB_OUTPUT
-        shell: bash
-      - name: Upgrade vagrant box
-        run: |
-          ln -sf hack/ci/Vagrantfile-flatcar Vagrantfile
-          vagrant box update
-      - uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a
-        with:
-          name: image
-          path: .
-      - name: Boot Virtual Machine
-        run: make vagrant-up-flatcar
-      - name: Show environment information
-        run: |
-          $RUN kubectl wait --for=condition=ready --timeout=600s node localhost
-          $RUN kubectl get nodes -o wide
-      - name: Run E2E tests
-        run: $RUN hack/ci/e2e-flatcar-dev-container.sh
-      - name: Run Flaky E2E tests
-        continue-on-error: true
-        run: |
-          $RUN "echo \"export E2E_TEST_FLAKY_TESTS_ONLY=true\" >> /vagrant/hack/ci/env-flatcar.sh"
-          $RUN hack/ci/e2e-flatcar-dev-container.sh
+    # TODO(saschagrunert): re-enable when
+    # https://github.com/actions/runner-images/issues/8730 is resolved
+    if: false
+    needs: image
+    runs-on: macos-12
+    timeout-minutes: 90
+    env:
+      RUN: ./hack/ci/run-flatcar.sh
+    steps:
+       - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v3.5.2
+       - name: Vagrant box version
+         id: vagrant-box
+         run: |
+           echo "version=$(curl -s  https://stable.release.flatcar-linux.net/amd64-usr/current/flatcar_production_vagrant.json | jq '.versions[0].version' | tr -d '".')" >> $GITHUB_OUTPUT
+         shell: bash
+       - name: Upgrade vagrant box
+         run: |
+           ln -sf hack/ci/Vagrantfile-flatcar Vagrantfile
+           vagrant box update
+       - uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a
+         with:
+           name: image
+           path: .
+       - name: Boot Virtual Machine
+         run: make vagrant-up-flatcar
+       - name: Show environment information
+         run: |
+           $RUN kubectl wait --for=condition=ready --timeout=600s node localhost
+           $RUN kubectl get nodes -o wide
+       - name: Run E2E tests
+         run: $RUN hack/ci/e2e-flatcar-dev-container.sh
+       - name: Run Flaky E2E tests
+         continue-on-error: true
+         run: |
+           $RUN "echo \"export E2E_TEST_FLAKY_TESTS_ONLY=true\" >> /vagrant/hack/ci/env-flatcar.sh"
+           $RUN hack/ci/e2e-flatcar-dev-container.sh
 
   baseprofiles:
+    # TODO(saschagrunert): re-enable when
+    # https://github.com/actions/runner-images/issues/8730 is resolved
+    if: false
     needs: image
     runs-on: macos-12
     timeout-minutes: 90
diff --git a/test/e2e_test.go b/test/e2e_test.go
index d8332823ba..6fa350dafb 100644
--- a/test/e2e_test.go
+++ b/test/e2e_test.go
@@ -76,10 +76,13 @@ func (e *e2e) TestSecurityProfilesOperator() {
 			"Seccomp: Verify base profile merge",
 			e.testCaseBaseProfile,
 		},
-		{
-			"Seccomp: Verify base profile merge from OCI registry",
-			e.testCaseBaseProfileOCI,
-		},
+		// TODO: re-enable when we found a workaround to the flaky GitHub registry connection
+		/*
+			{
+				"Seccomp: Verify base profile merge from OCI registry",
+				e.testCaseBaseProfileOCI,
+			},
+		*/
 		{
 			"Seccomp: Allowed syscalls",
 			e.testCaseAllowedSyscalls,
diff --git a/test/tc_base_profiles_oci_test.go b/test/tc_base_profiles_oci_test.go
index 06f13d6c1f..d5a12cb3ea 100644
--- a/test/tc_base_profiles_oci_test.go
+++ b/test/tc_base_profiles_oci_test.go
@@ -23,6 +23,7 @@ import (
 	"time"
 )
 
+//nolint:unused // test is flaky and therefore got deactivated
 func (e *e2e) testCaseBaseProfileOCI([]string) {
 	e.seccompOnlyTestCase()