Skip to content

Commit 06f7cf9

Browse files
leemingeerleemingeer
committed
nfd-topology-updater add pods fingerprint by default
1 parent 28e18c4 commit 06f7cf9

File tree

4 files changed

+27
-28
lines changed

4 files changed

+27
-28
lines changed

‎deployment/helm/node-feature-discovery/templates/topologyupdater.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ spec:
6666
- "-key-file=/etc/kubernetes/node-feature-discovery/certs/tls.key"
6767
- "-cert-file=/etc/kubernetes/node-feature-discovery/certs/tls.crt"
6868
{{- end }}
69-
{{- if .Values.topologyUpdater.podSetFingerprint }}
70-
- "-pods-fingerprint"
69+
{{- if .Values.topologyUpdater.disablePodSetFingerprint | empty | not }}
70+
- "-pods-fingerprint=false"
7171
{{- end }}
7272
{{- if .Values.topologyUpdater.kubeletConfigPath | empty | not }}
7373
- "-kubelet-config-uri=file:///host-var/kubelet-config"

‎deployment/helm/node-feature-discovery/values.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,7 @@ topologyUpdater:
483483
annotations: {}
484484
daemonsetAnnotations: {}
485485
affinity: {}
486-
podSetFingerprint: true
486+
disablePodSetFingerprint:
487487

488488
gc:
489489
enable: true

‎docs/deployment/helm.md

+24-24
Original file line numberDiff line numberDiff line change
@@ -161,31 +161,31 @@ API's you need to install the prometheus operator in your cluster.
161161

162162
### Topology updater parameters
163163

164-
| Name | Type | Default | description |
165-
|-----------------------------------------------|--------|-------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
166-
| `topologyUpdater.*` | dict | | NFD Topology Updater configuration |
167-
| `topologyUpdater.enable` | bool | false | Specifies whether the NFD Topology Updater should be created |
168-
| `topologyUpdater.createCRDs` | bool | false | Specifies whether the NFD Topology Updater CRDs should be created |
169-
| `topologyUpdater.serviceAccount.create` | bool | true | Specifies whether the service account for topology updater should be created |
170-
| `topologyUpdater.serviceAccount.annotations` | dict | {} | Annotations to add to the service account for topology updater |
171-
| `topologyUpdater.serviceAccount.name` | string | | The name of the service account for topology updater to use. If not set and create is true, a name is generated using the fullname template and `-topology-updater` suffix |
172-
| `topologyUpdater.rbac.create` | bool | true | Specifies whether to create [RBAC][rbac] configuration for topology updater |
173-
| `topologyUpdater.metricsPort` | integer | 8081 | Port on which to expose prometheus metrics |
174-
| `topologyUpdater.kubeletConfigPath` | string | "" | Specifies the kubelet config host path |
175-
| `topologyUpdater.kubeletPodResourcesSockPath` | string | "" | Specifies the kubelet sock path to read pod resources |
176-
| `topologyUpdater.updateInterval` | string | 60s | Time to sleep between CR updates. Non-positive value implies no CR update. |
177-
| `topologyUpdater.watchNamespace` | string | `*` | Namespace to watch pods, `*` for all namespaces |
164+
| Name | Type | Default | description |
165+
|-----------------------------------------------|--------|-------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
166+
| `topologyUpdater.*` | dict | | NFD Topology Updater configuration |
167+
| `topologyUpdater.enable` | bool | false | Specifies whether the NFD Topology Updater should be created |
168+
| `topologyUpdater.createCRDs` | bool | false | Specifies whether the NFD Topology Updater CRDs should be created |
169+
| `topologyUpdater.serviceAccount.create` | bool | true | Specifies whether the service account for topology updater should be created |
170+
| `topologyUpdater.serviceAccount.annotations` | dict | {} | Annotations to add to the service account for topology updater |
171+
| `topologyUpdater.serviceAccount.name` | string | | The name of the service account for topology updater to use. If not set and create is true, a name is generated using the fullname template and `-topology-updater` suffix |
172+
| `topologyUpdater.rbac.create` | bool | true | Specifies whether to create [RBAC][rbac] configuration for topology updater |
173+
| `topologyUpdater.metricsPort` | integer | 8081 | Port on which to expose prometheus metrics |
174+
| `topologyUpdater.kubeletConfigPath` | string | "" | Specifies the kubelet config host path |
175+
| `topologyUpdater.kubeletPodResourcesSockPath` | string | "" | Specifies the kubelet sock path to read pod resources |
176+
| `topologyUpdater.updateInterval` | string | 60s | Time to sleep between CR updates. Non-positive value implies no CR update. |
177+
| `topologyUpdater.watchNamespace` | string | `*` | Namespace to watch pods, `*` for all namespaces |
178178
| `topologyUpdater.podSecurityContext` | dict | {} | [PodSecurityContext](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#set-the-security-context-for-a-pod) holds pod-level security attributes and common container settings |
179-
| `topologyUpdater.securityContext` | dict | {} | Container [security settings](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#set-the-security-context-for-a-container) |
180-
| `topologyUpdater.resources` | dict | {} | Topology updater pod [resources management](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/) |
181-
| `topologyUpdater.nodeSelector` | dict | {} | Topology updater pod [node selector](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector) |
182-
| `topologyUpdater.tolerations` | dict | {} | Topology updater pod [node tolerations](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) |
183-
| `topologyUpdater.annotations` | dict | {} | Topology updater pod [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
184-
| `topologyUpdater.daemonsetAnnotations` | dict | {} | Topology updater daemonset [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
185-
| `topologyUpdater.affinity` | dict | {} | Topology updater pod [affinity](https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/) |
186-
| `topologyUpdater.config` | dict | | [configuration](../reference/topology-updater-configuration-reference) |
187-
| `topologyUpdater.podSetFingerprint` | bool | false | Enables compute and report of pod fingerprint in NRT objects. |
188-
| `topologyUpdater.kubeletStateDir` | string | /var/lib/kubelet | Specifies kubelet state directory path for watching state and checkpoint files. Empty value disables kubelet state tracking. |
179+
| `topologyUpdater.securityContext` | dict | {} | Container [security settings](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#set-the-security-context-for-a-container) |
180+
| `topologyUpdater.resources` | dict | {} | Topology updater pod [resources management](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/) |
181+
| `topologyUpdater.nodeSelector` | dict | {} | Topology updater pod [node selector](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector) |
182+
| `topologyUpdater.tolerations` | dict | {} | Topology updater pod [node tolerations](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) |
183+
| `topologyUpdater.annotations` | dict | {} | Topology updater pod [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
184+
| `topologyUpdater.daemonsetAnnotations` | dict | {} | Topology updater daemonset [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
185+
| `topologyUpdater.affinity` | dict | {} | Topology updater pod [affinity](https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/) |
186+
| `topologyUpdater.config` | dict | | [configuration](../reference/topology-updater-configuration-reference) |
187+
| `topologyUpdater.disablePodSetFingerprint` | bool | false | Disables compute and report of pod fingerprint in NRT objects. |
188+
| `topologyUpdater.kubeletStateDir` | string | /var/lib/kubelet | Specifies kubelet state directory path for watching state and checkpoint files. Empty value disables kubelet state tracking. |
189189

190190
### Garbage collector parameters
191191

‎go.mod

-1
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,6 @@ replace (
218218
k8s.io/controller-manager => k8s.io/controller-manager v0.29.0
219219
k8s.io/cri-api => k8s.io/cri-api v0.29.0
220220
k8s.io/csi-translation-lib => k8s.io/csi-translation-lib v0.29.0
221-
k8s.io/endpointslice => k8s.io/endpointslice v0.29.0
222221
k8s.io/kube-aggregator => k8s.io/kube-aggregator v0.29.0
223222
k8s.io/kube-controller-manager => k8s.io/kube-controller-manager v0.29.0
224223
k8s.io/kube-proxy => k8s.io/kube-proxy v0.29.0

0 commit comments

Comments
 (0)