Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kwok node stuck in a NotReady state after using kustomize to deploy kwok #1325

Closed
5 tasks
network-charles opened this issue Mar 10, 2025 · 4 comments · Fixed by #1327
Closed
5 tasks

kwok node stuck in a NotReady state after using kustomize to deploy kwok #1325

network-charles opened this issue Mar 10, 2025 · 4 comments · Fixed by #1327
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@network-charles
Copy link
Contributor

network-charles commented Mar 10, 2025

How to use it?

  • kwok
  • kwokctl --runtime=docker (default runtime)
  • kwokctl --runtime=binary
  • kwokctl --runtime=nerdctl
  • kwokctl --runtime=kind

What happened?

When deploying kwok using kustomize, it deploys successfully, but when you create a new fake node, it is stuck in a NotReady state.

I believe that the required "default custom resources (CRs) of stages" is missing. When I install this myself, it worked.

My suggested fix is to include stage to the kustomize definition.

resources:
- ../stage

Let me know what you think, @wzshiming.

What did you expect to happen?

I expected the node to be in a ready state.

kwok-node-1          Ready    agent           18s     fake

How can we reproduce it (as minimally and precisely as possible)?

  1. Deploy kwok using kustomize
  2. Create a fake node

Anything else we need to know?

No response

Kwok version

$ kwok --version
# Its not showing an output on my mac. I installed kwok using homebrew

$ kwokctl --version
kwokctl version v0.6.1 go1.22.3 (darwin/amd64)

OS version

# On Darwin:
$ uname -a
Darwin macs-MacBook-Pro.local 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:00 PDT 2024; root:xnu-10063.141.2~1/RELEASE_X86_64 x86_64
@network-charles network-charles added the kind/bug Categorizes issue or PR as related to a bug. label Mar 10, 2025
@wzshiming
Copy link
Member

In fact, this is a limitation of apiserver, CRD and its CR cannot be applied at the same time, they have to be separated twice.

@network-charles
Copy link
Contributor Author

Ok, so does it mean that the kustomize section in the docs is missing a critical step about applying the CR?

@wzshiming
Copy link
Member

Yes, it is true that this section has not been maintained for a long time, and has been stuck in a state before CRD configuration kwok was available.

@network-charles
Copy link
Contributor Author

Alright, I will submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants