Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API/KIND version #5792

Open
2 tasks done
shunki-fujita opened this issue Oct 29, 2024 · 4 comments
Open
2 tasks done

Update API/KIND version #5792

shunki-fujita opened this issue Oct 29, 2024 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@shunki-fujita
Copy link

Eschewed features

  • This issue is not requesting templating, unstuctured edits, build-time side-effects from args or env vars, or any other eschewed feature.

What would you like to have added?

The version specified in the Makefile is out of date and needs to be updated.

KIND_VERSION := "v0.11.1"
API_VERSION ?= "v1.21.2"

Why is this needed?

Can't get information on recently added APIs like ValidatingAdmissionPolicy.
https://kubernetes.io/docs/reference/access-authn-authz/validating-admission-policy/

Can you accomplish the motivating task without this feature, and if so, how?

It is possible by manually updating the version and building

What other solutions have you considered?

Have no other ideas.

Anything else we should know?

No response

Feature ownership

  • I am interested in contributing this feature myself! 🎉
@shunki-fujita shunki-fujita added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 29, 2024
@shunki-fujita
Copy link
Author

Hello, @koba1t

I'm currently working on updating the API_VERSION. The policy written below is outdated, so I'm unsure which version should be specified instead.
https://github.com/kubernetes-sigs/kustomize/tree/master/kyaml/openapi#choose-the-new-version-to-use

Do you have any thoughts on this matter?

@chansuke
Copy link
Member

chansuke commented Nov 2, 2024

@shunki-fujita
Thank you so much for your work!

This is just my personal opinion.
I'd like to choose v1.30.4 according to the documentation.

The reason is below:

  • v1.30.4 maintains compatibility with older versions while also ensuring access to new features.
  • v1.31.0 introduces breaking changes, and compared to that, v1.30.4 appears to be more stable.

And the direction you taking is good IMHO.

@shunki-fujita
Copy link
Author

@chansuke
I'll proceed with that approach. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants