-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project type to support hybrids SDK projects #1171
Add project type to support hybrids SDK projects #1171
Conversation
/assign @mengqiy |
53e427b
to
6b69cf9
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
I'm not sure if this is the right way to approach this, since using this approach plugins will be in-tree. That is not the goal.
cc: @droot @DirectXMan12
@@ -108,6 +108,7 @@ func (o *projectOptions) bindCmdlineFlags(cmd *cobra.Command) { | |||
"defaults to the go package of the current working directory.") | |||
cmd.Flags().StringVar(&o.project.Domain, "domain", "my.domain", "domain for groups") | |||
cmd.Flags().StringVar(&o.project.Version, "project-version", project.Version2, "project version") | |||
cmd.Flags().StringVar(&o.project.ProjectType, "type", project.Go, "project type") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest keep this flag hidden from the users until it's ready.
You can achieve that with cmd.Flags().MarkHidden("flag name")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
6b69cf9
to
ecd9b26
Compare
I think that would make sense we have the info in the PROJECT file which defines the spec/attributes of it. IHMO it is a simple and easy solution to allow hybrid ones. So, based on the PROJECT file we could do any further implementation. Also, in POV it could keep simple do things as for example, allow us to scaffold the Makefile according to the type and add the plugins and etc, allow the plugins know how to dealing with the code, allow the tool know how to dealing with the project and etc .. WDYT? |
do we currently not store initial plugin info? Agree with camilla here -- it seems like we should store the general project structure for later so that you don't have to specify |
ecd9b26
to
36a8183
Compare
@camilamacedo86: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @mengqiy and @DirectXMan12, Could we move forward so with this one? Would you like to change anything in the way that it was done? |
36a8183
to
e4fdc6a
Compare
@mengqiy it is rebased with the master now in order to pass in the prow tests. |
HI @mengqiy, @DirectXMan12 agreed with this change as well here; #1171 (comment). WDYT, could we move forward with this one? |
@camilamacedo86 @DirectXMan12 @hasbro17 We are working on a proposal that will address this and should have something posted soon. In the meantime, the working POC is at https://github.com/joelanford/kubebuilder-exp if you want an early look. The idea is:
I'm not opposed to introducing a new ProjectType field if that makes more sense. That probably needs more discussion. I'm in favor of leaving this on hold, pending our proposal. |
closing as per the feature branch and related discussion. |
@camilamacedo86: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
Add project type to support hybrids SDK projects
Motivation
Closes: #879