Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scaffold: Don't hardcode the boilerplate path in the Makefile #1016

Merged
merged 1 commit into from
Jan 7, 2020
Merged

scaffold: Don't hardcode the boilerplate path in the Makefile #1016

merged 1 commit into from
Jan 7, 2020

Conversation

dlespiau
Copy link
Contributor

@dlespiau dlespiau commented Sep 24, 2019 •
edited
Loading

init has a --path argument that specifies where the boilerplate file should be
written to. Unfortunately, the Makefile generation wasn't taking it into
account.

@dlespiau
scaffold: Don't hardcode the boilerplate path in the Makefile
4240869 
init has a --path argument that specifies where the boilerplate file should be
written to. Unforunately, the Makefile generation wasn't taking it into
account.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2019
@dlespiau
Copy link
Contributor Author

/assign @Liujingfang1

@dlespiau dlespiau changed the title scaffold: Don't hardcode the boilerplate path in the Makefile [WIP] scaffold: Don't hardcode the boilerplate path in the Makefile Sep 24, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2019
@dlespiau
Copy link
Contributor Author

dlespiau commented Sep 24, 2019 •
edited
Loading

Unfortunately kubebuilder create api then fails with:

2019/09/24 17:56:13 error scaffolding APIs: open hack/boilerplate.go.txt: no such file or directory

I guess we should store some state in PROJECT to be shared between sub-command invocations.

@dlespiau
Copy link
Contributor Author

/unassign @Liujingfang1

@DirectXMan12
Copy link
Contributor

yeah, preserving those in the project file seems reasonable

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 25, 2019
@DirectXMan12 DirectXMan12 changed the title [WIP] scaffold: Don't hardcode the boilerplate path in the Makefile scaffold: Don't hardcode the boilerplate path in the Makefile Jan 7, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2020
@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, dlespiau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit fed08ef into kubernetes-sigs:master Jan 7, 2020
@Adirio Adirio mentioned this pull request Jan 8, 2020
Merged
Adirio added a commit to Adirio/kubebuilder that referenced this pull request Jan 8, 2020
@Adirio
Hotfix for TRAVIS error introduced by kubernetes-sigs#1016
6fa8b98 
Signed-off-by: Adrian Orive <[email protected]>
@Adirio Adirio mentioned this pull request Jan 8, 2020
Closed
Adirio added a commit to Adirio/kubebuilder that referenced this pull request Jan 8, 2020
@Adirio
Hotfix for TRAVIS error introduced by kubernetes-sigs#1016
b7c6ee9 
Signed-off-by: Adrian Orive <[email protected]>
Adirio added a commit to Adirio/kubebuilder that referenced this pull request Jan 8, 2020
@Adirio
Fix issue with Travis introduced by kubernetes-sigs#1016
1b4c224 
Signed-off-by: Adrian Orive <[email protected]>
This was referenced Jan 9, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

Assignees

@DirectXMan12 DirectXMan12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dlespiau @DirectXMan12 @fejta-bot @k8s-ci-robot @Liujingfang1