kubebuilder update generates Gopkg.toml with hardcoded versions

[alvaroaleman]

The kubebuilder update command currently generates a Gopkg.toml with hardcoded versions:

kubebuilder/cmd/vendor/sigs.k8s.io/controller-tools/pkg/scaffold/project/gopkg.go

Lines 147 to 153 in 0f8f2d8

	[[constraint]]
	name="sigs.k8s.io/controller-runtime"
	version="v0.1.1"
	[[constraint]]
	name="sigs.k8s.io/controller-tools"
	version="v0.1.1"

This is made worse by the fact that this is below a header # STANZAS BELOW ARE GENERATED AND MAY BE WRITTEN - DO NOT MODIFY BELOW THIS LINE. which makes it look like end-users should not touch that part.

[droot]

@alvaroaleman Though the version in the dep stanza is v0.1.1, dep will pick the v0.1.x where x being the latest patch version on v0.1.x (dep docs here). This is intentional because we want newly created Kubebuilder project to pick the latest stable version on 0.1.x of controller-runtime and controller-tools.

And if you want to update to new version to pick recent fixes on v0.1.x, you can run 'dep ensure -update sigs.k8s.io/controller-runtime`.

[alvaroaleman]

@droot I see, thanks for the clarification. I find that a little unintuitive tbh but that is obviously something on dep side.

Maybe we can change the lines to version="^v0.1.1" to make this more obvious?

[justinsb]

I would +1 to changing this. I'm using go modules, and it's confusing to have a version specified in Gopkg.toml that isn't actually what you intend to use.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[DirectXMan12]

No longer using dep, closing