Goimports error in Travis

[Adirio]

Travis is failing several PR due to a goimports linting error. The error message is:

$ ./scripts/verify.sh
running go vet
running go fmt
running golangci-lint
pkg/scaffold/v2/controller/controller_suitetest.go:26: File is not goimports-ed (goimports)
"sigs.k8s.io/kubebuilder/pkg/scaffold/v2"
The command "./scripts/verify.sh" exited with 1.

Affected PR:

• Unification of receiver names #1186: Travis
• Add interface validation check for missing types #1248: Travis
• Named arguments for path formatting #1252: Travis
• Split injecting fields and validating files #1265: Travis

/kind bug

[Adirio]

#1186 and #1252 do modify that file and #1186 doesn't even touch the import section. Additionally, #1248 and #1265 do not modify that file at all, so the error doesn't seem to be related to anything done in those PR.

The check has been introduced in #1292 and #1198 is the only thing that was merged into master between #1292 branch start and its merge. I have tried to run gofmt and goimports to that file and they do not modify anything.

@camilamacedo86 Could you please have a look at this as my linter is warning about less things than yours?

[camilamacedo86]

@Adirio,

The error faced is:

Note that you can use the lint to fix it automatically by adding the flag fix as follows and the running the lint target make lint

[camilamacedo86]

It is fixed here: https://github.com/kubernetes-sigs/kubebuilder/pull/1293/files#diff-ec3d96c196a007869f26993a5a8a7492R26

[Adirio]

Why does it need to use v2 as import alias if the package is already called v2?

[camilamacedo86]

Hi @Adirio the lint checks are usually based in good practices. I understand that it is suggesting to add the alias in order to make implicit that it came from v2 and not another version. However, I did not check it further. Please, feel free to look for its explanation in its doc and implementation which is here: https://godoc.org/github.com/Go-zh/tools/cmd/goimports.

[camilamacedo86]

Hi @Adirio,

It is fixed. Could we close this one? If not, what is missing to address here?