Skip to content

MIgrate build and promotion of images from Kubebuilder GCP #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
camilamacedo86 opened this issue Jul 5, 2024 · 5 comments
Closed
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@camilamacedo86
Copy link
Member

We are using the project to generate the image gcr.io/kubebuilder/pr-verifier:$TAG_NAME. This image, generated by the project https://github.com/kubernetes-sigs/kubebuilder-release-tools, is used in the CI to verify PR emojis for release notes.

The goal of this one is move forward and use he regular image promotion / k8s infra to promote those images.

Be aware that the current images will be unavailable from March 18, 2025.

Motivation: kubernetes/k8s.io#2647 and kubernetes-sigs/kubebuilder#3907

@camilamacedo86 camilamacedo86 added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 5, 2024
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Jul 18, 2024

Following some important info to help out on this one

Something like:


docker build \
    -t gcr.io/kubebuilder/pr-verifier:$TAG_NAME \
    -f Dockerfile \

@TAM360
Copy link

TAM360 commented Jul 18, 2024

@camilamacedo86 I am interested in working on this task.

@camilamacedo86
Copy link
Member Author

It seems out of the scope but we probably need add more people in : https://github.com/kubernetes/k8s.io/pull/4586/files#r1682542243

(Just adding here for now)

@camilamacedo86
Copy link
Member Author

@TAM360

Thank you a lot for your terrfic work and help us understand how would be the process moving forward.
This project does not do too much today and has no maintainers

Therefore, due the fact of this image only check the PR title it seems that make no sense we need to have the infrastructure for each and have a process where we need to build image in stage and then publish for prod. It seems that we can create a shell script or let people use the same implementation in other ways.

So, lets close this one

@sbueringer ^ +1 for your thought that the work is not valid here.

@sbueringer
Copy link
Member

Sounds reasonable to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants