Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reword comments and fix typo in buildcontext.go #3690

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Reword comments and fix typo in buildcontext.go #3690

merged 1 commit into from
Aug 6, 2024

Conversation

joycecodes
Copy link
Contributor

Non-functional change.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 20, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 20, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @joycecodes!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @joycecodes. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 20, 2024
stmcginnis
stmcginnis reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some slight improvements here, but nothing I would deem too important. But we will need the EasyCLA issues sorted before we can accept this. Please address the issues pointed out by the comment from EasyCLA and let us know if anything doesn't make sense.

pkg/build/nodeimage/buildcontext.go Outdated
@@ -125,7 +125,7 @@ func (c *buildContext) buildImage(bits kube.Bits) error {
return err
}

// pre-pull images that were not part of the build and write CNI / storage
// pre-pull images that were not part of the build and write CNI / Storage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storage isn't a proper name here, I don't think it needs to be capitalized.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CNI is only capitalized because it is an acronym AND a proper name. In this case storage is neither.

pkg/build/nodeimage/buildcontext.go Outdated
@@ -249,7 +249,7 @@ func (c *buildContext) prePullImagesAndWriteManifests(bits kube.Bits, parsedVers
c.logger.Errorf("Image build Failed! Failed write default Storage Manifest: %v", err)
return nil, err
}
// all builds should install the default storage driver images currently
// all builds should install the default Storage driver images currently
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@kundan2707
Copy link
Contributor

@joycecodes please sign cncf-cla

@kundan2707
Copy link
Contributor

/easycla

@joycecodes
Copy link
Contributor Author

/check-cla

@stmcginnis
Copy link
Contributor

/easycla

@stmcginnis
Copy link
Contributor

It looks like maybe your second commit is OK with easycla but not your first one. It would be good to squash commits anyway.

You can squash you commits and update it to be the correct author using something like the following:

git rebase -i HEAD~2
# change the second commit to squash, fix up combined commit message
git commit --amend --author="First Last <[email protected]>" --no-edit
git push -f origin comments

We need to make sure changes are covered by the CLA before we can consider accepting them.

@joycecodes joycecodes force-pushed the comments branch 2 times, most recently from 27528b1 to 7c0f32e Compare August 5, 2024 00:12
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 5, 2024
@joycecodes
Copy link
Contributor Author

It looks like maybe your second commit is OK with easycla but not your first one. It would be good to squash commits anyway.

You can squash you commits and update it to be the correct author using something like the following:

git rebase -i HEAD~2
# change the second commit to squash, fix up combined commit message
git commit --amend --author="First Last <[email protected]>" --no-edit
git push -f origin comments

We need to make sure changes are covered by the CLA before we can consider accepting them.

Thank you for your patience!

@BenTheElder
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2024
@stmcginnis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2024
BenTheElder
BenTheElder reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, the rest looks good!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2024
BenTheElder
BenTheElder reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, joycecodes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 00d659b into kubernetes-sigs:main Aug 6, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@stmcginnis stmcginnis stmcginnis left review comments

@aojea aojea Awaiting requested review from aojea

Assignees

@BenTheElder BenTheElder

@stmcginnis stmcginnis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joycecodes @k8s-ci-robot @kundan2707 @stmcginnis @BenTheElder