fix: ensure proper kubectl is used

[rjsadow]

Ensure that the kubectl built is the one used throughout the script.

ref: kubernetes/test-infra#30345

/cc @BenTheElder @aojea

[stmcginnis]

/lgtm

[BenTheElder]

I don't think that works? For one thing Kubernetes doesn't build to bin/

[rjsadow]

You're right, I was looking at the wrong dir. I think it'll need to be export PATH="${PWD}/_output/bin/kubectl:$PATH" . This is based on https://github.com/kubernetes/kubernetes/blob/master/build/root/Makefile#L45-L46 and running e2e-k8s.sh locally.

[rjsadow]

Still isn't the right fix. Looking more.

[aojea]

check in the kubernetes/hack folder, there are multiple scripts that looks for the kubectl binary there

[rjsadow]

😓 PATH="${PWD}/_output/bin/kubectl:$PATH" vs PATH="${PWD}/_output/bin:$PATH".... Too much time spent on realizing that. Update incoming.

[BenTheElder]

I forget if we can rely on this always being the case but we can start here. When you build dockerized vs not the k8s build system emits to different subpaths under _output, but they might both be linked to this path? In the past in kubernetes upstream we've had to use a small utility to check multiple locations.

If this is working in CI we can start here though.

[aojea]

/test pull-kind-conformance-parallel-dual-stack-ipv4-ipv6

not related, this is because kubernetes/kubernetes#119927

This looks correct now

+ kubectl version
Client Version: v1.29.0-alpha.0.66+6e0cb243d57592
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.29.0-alpha.0.66+6e0cb243d57592

/assign @BenTheElder

[rjsadow]

/retest

[BenTheElder]

/lgtm
/approve

w/ comment about why we may need a more elaborate follow-up

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment