Skip to content

perf: Optimistically delete from the cache after launch #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
+4 −0
Merged

perf: Optimistically delete from the cache after launch #2380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/controllers/nodeclaim/lifecycle/launch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ func (l *Launch) Reconcile(ctx context.Context, nodeClaim *v1.NodeClaim) (reconc
if cond := nodeClaim.StatusConditions().Get(v1.ConditionTypeLaunched); !cond.IsUnknown() {
// Ensure that we always set the status condition to the latest generation
nodeClaim.StatusConditions().Set(*cond)
if cond.IsTrue() {
// Once the NodeClaim has successfully marked as launched, we no longer need to store it
l.cache.Delete(string(nodeClaim.UID))
}
return reconcile.Result{}, nil
}

Expand Down
Loading