test: deflake NodeClaim and presubmit tests

[rschalo]

Fixes #N/A

Description
The presubmit test was calling cluster.Nodes() which returns nodes based on a map. This adds a sort so the nodes are deterministically selected for churn.

Deflakes registration by adding time since it can take longer than 1 minute to move from TTL to deletion completing:

     {"level":"DEBUG","time":"2025-05-21T19:04:08.017Z","logger":"controller","caller":"lifecycle/liveness.go:69","message":"terminating due to registration ttl","commit":"91d8ecc","controller":"nodeclaim.lifecycle","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","NodeClaim":{"name":"fighterribbon-23-rfpvpgytno"},"namespace":"","name":"fighterribbon-23-rfpvpgytno","reconcileID":"ea4d5c90-7f46-4f6b-80d6-3e3d38602624","provider-id":"aws:///us-east-2b/i-0349b1aa449d49a2d","ttl":"15m0s"}
    {"level":"INFO","time":"2025-05-21T19:05:25.282Z","logger":"controller","caller":"lifecycle/controller.go:242","message":"deleted nodeclaim","commit":"91d8ecc","controller":"nodeclaim.lifecycle","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","NodeClaim":{"name":"fighterribbon-23-rfpvpgytno"},"namespace":"","name":"fighterribbon-23-rfpvpgytno","reconcileID":"9be9e594-65de-45de-a195-10b54561cf8b","provider-id":"aws:///us-east-2b/i-0349b1aa449d49a2d"}

Also fixes a case where the old test providerID failed the regex. Having no providerID accomplishes the desired garbage collection behavior.

How was this change tested?
make upstream-e2etests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[engedaam]

/lgtm

[coveralls]

Pull Request Test Coverage Report for Build 15192600380

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 3 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.008%) to 81.975%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/controllers/provisioning/scheduling/nodeclaim.go	3	89.66%

Totals
Change from base Build 15175060207:	-0.008%
Covered Lines:	10178
Relevant Lines:	12416

---

💛 - Coveralls

[rschalo]

/test ?

[k8s-ci-robot]

@rschalo: The following commands are available to trigger optional jobs:

/test pull-karpenter-test-1-26

/test pull-karpenter-test-1-27

/test pull-karpenter-test-1-28

/test pull-karpenter-test-1-29

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rschalo]

/ok-to-test

[rschalo]

/retest

[rschalo]

/test pull-karpenter-test-1-27

[jonathan-innis]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, jonathan-innis, rschalo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jonathan-innis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[flavono123]

may i retest what i submitted already which are failed for "does not delete nodes with pod churn, deletes nodes without pod churn", or should i?

#2090 #2054