Skip to content

Adding missing libgpg-error.so.0 required by nvme-cli#1760

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
pwschuurman:add-missing-libgpg-error
Jun 25, 2024
Merged

Adding missing libgpg-error.so.0 required by nvme-cli#1760
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
pwschuurman:add-missing-libgpg-error

Conversation

@pwschuurman
Copy link
Copy Markdown
Contributor

@pwschuurman pwschuurman commented Jun 25, 2024 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
The command /usr/bin/nvme requires this shared library. This is used to validate nvme device symlinks. This library is required in Bookworm (after we migrated from Bullseye in #1694)

Validated by running ./hack/verify_docker_deps.h

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes NVMe support in NodeStage and NodePublish

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2024
@pwschuurman
Copy link
Copy Markdown
Contributor Author

pwschuurman commented Jun 25, 2024

/assign @Sneha-at

@pwschuurman pwschuurman mentioned this pull request Jun 25, 2024
Merged
@Sneha-at
Copy link
Copy Markdown
Contributor

Sneha-at commented Jun 25, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman, Sneha-at

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pwschuurman
Copy link
Copy Markdown
Contributor Author

pwschuurman commented Jun 25, 2024

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1ba11f6 into kubernetes-sigs:master Jun 25, 2024
@pwschuurman
Copy link
Copy Markdown
Contributor Author

pwschuurman commented Jun 25, 2024

/cherry-pick release-1.14

@pwschuurman
Copy link
Copy Markdown
Contributor Author

pwschuurman commented Jun 25, 2024

/cherry-pick release-1.13

@pwschuurman
Copy link
Copy Markdown
Contributor Author

pwschuurman commented Jun 25, 2024

/cherry-pick release-1.12

@pwschuurman
Copy link
Copy Markdown
Contributor Author

pwschuurman commented Jun 25, 2024

/cherry-pick release-1.11

@pwschuurman
Copy link
Copy Markdown
Contributor Author

pwschuurman commented Jun 25, 2024

/cherry-pick release-1.10

@pwschuurman
Copy link
Copy Markdown
Contributor Author

pwschuurman commented Jun 25, 2024

/cherry-pick release-1.9

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Jun 25, 2024

@pwschuurman: new pull request created: #1765

Details

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Jun 25, 2024
Merged
Closed
@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Jun 25, 2024

@pwschuurman: new pull request created: #1766

Details

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Jun 25, 2024

@pwschuurman: new pull request created: #1767

Details

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Jun 25, 2024
Closed
Closed
@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Jun 25, 2024

@pwschuurman: new pull request created: #1768

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Jun 25, 2024

@pwschuurman: new pull request created: #1769

Details

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 25, 2024
Closed
@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Jun 25, 2024

@pwschuurman: new pull request created: #1770

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amacaskill amacaskill Awaiting requested review from amacaskill

@leiyiz leiyiz Awaiting requested review from leiyiz

Assignees

@Sneha-at Sneha-at

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pwschuurman @Sneha-at @k8s-ci-robot @k8s-infra-cherrypick-robot