Fix error when no compute endpoint is passed#1620
Merged
Merged
Conversation
k8s-ci-robot
added
do-not-merge/release-note-label-needed
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/S
Contributor
Author
|
/test pull-gcp-compute-persistent-disk-csi-driver-e2e |
Contributor
Author
|
/test all |
Sneha-at
changed the title
Sneha-at
force-pushed
the
add_staging_support
branch
from
c822096 to
6a01a7c
Compare
Contributor
Author
|
/test all |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/test pull-gcp-compute-persistent-disk-csi-driver-e2e |
pwschuurman
reviewed
Feb 23, 2024
Sneha-at
force-pushed
the
add_staging_support
branch
from
6a01a7c to
2bf0478
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pwschuurman, Sneha-at The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
Author
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Sneha-at
force-pushed
the
add_staging_support
branch
from
2bf0478 to
7358870
Compare
k8s-ci-robot
removed
the
lgtm
Contributor
Author
|
/remove-hold |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
release-note-none
Contributor
Author
|
/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration |
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
|
/cherry-pick release-1.13 |
|
@amacaskill: new pull request created: #1622 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes the driver error for empty compute endpoint string from #1586
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: