Skip to content

conformance: Add Cilium report for 1.2.1 #3578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

conformance: Add Cilium report for 1.2.1 #3578

merged 1 commit into from
Feb 11, 2025

Conversation

@sayboras
Copy link
Contributor

What type of PR is this?

/kind documentation
/area conformance

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 31, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 31, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @sayboras. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 31, 2025
@sayboras sayboras marked this pull request as ready for review January 31, 2025 11:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
@k8s-ci-robot k8s-ci-robot requested a review from Xunzhuo January 31, 2025 11:53
mlavacca
mlavacca reviewed Jan 31, 2025
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this report, @sayboras!

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2025
@LiorLieberman
Copy link
Member

LiorLieberman commented Jan 31, 2025 •
edited
Loading

/cc

@sayboras mind checking PercentageBasedRequestMirror conformance? you had previously mentioned that Cilium supports it. Ref #3508

@LiorLieberman
Copy link
Member

@sayboras any updates here?

@sayboras
Copy link
Contributor Author

👋 sorry for late reply.

This PR is for Cilium stable release 1.17, which only uses Gateway API tag version v1.2.1 (before the conformance test #3508 is merged).

I have run the test locally, it seems like the new HTTPRouteRequestPercentageMirror tests are passing as expected.

test_report.zip

@LiorLieberman
Copy link
Member

Thats awesome. Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2025
@LiorLieberman
Copy link
Member

/cc @mlavacca @robscott

@sayboras sayboras force-pushed the pr/tammach/cilium-1.17-1.2.1 branch from 23a2ce4 to e1549d4 Compare February 11, 2025 02:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2025
@robscott
Copy link
Member

Thanks @sayboras!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, sayboras

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@sayboras
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1ca9932 into kubernetes-sigs:main Feb 11, 2025
13 checks passed
@sayboras sayboras deleted the pr/tammach/cilium-1.17-1.2.1 branch February 11, 2025 07:22
sayboras added a commit to sayboras/gateway-api that referenced this pull request Feb 17, 2025
@sayboras
conformance: Correct Cilium version in 1.2.1
d72532c 
The recently added Cilium conformance report is still with main version,
which was recently fixed in cilium/cilium#37671.

Relates: kubernetes-sigs#3578.

Signed-off-by: Tam Mach <[email protected]>
@sayboras sayboras mentioned this pull request Feb 17, 2025
Merged
k8s-ci-robot pushed a commit that referenced this pull request Feb 26, 2025
@sayboras
conformance: Correct Cilium version in 1.2.1 (#3622)
000fcbc 
The recently added Cilium conformance report is still with main version,
which was recently fixed in cilium/cilium#37671.

Relates: #3578.

Signed-off-by: Tam Mach <[email protected]>
LiorLieberman pushed a commit to LiorLieberman/gateway-api that referenced this pull request Feb 26, 2025
@sayboras @LiorLieberman
conformance: Correct Cilium version in 1.2.1 (kubernetes-sigs#3622)
08f3d6e 
The recently added Cilium conformance report is still with main version,
which was recently fixed in cilium/cilium#37671.

Relates: kubernetes-sigs#3578.

Signed-off-by: Tam Mach <[email protected]>
EyalPazz pushed a commit to EyalPazz/gateway-api that referenced this pull request Feb 27, 2025
@sayboras @EyalPazz
conformance: Correct Cilium version in 1.2.1 (kubernetes-sigs#3622)
7ce52e2 
The recently added Cilium conformance report is still with main version,
which was recently fixed in cilium/cilium#37671.

Relates: kubernetes-sigs#3578.

Signed-off-by: Tam Mach <[email protected]>
EyalPazz pushed a commit to EyalPazz/gateway-api that referenced this pull request Feb 27, 2025
@sayboras @EyalPazz
conformance: Correct Cilium version in 1.2.1 (kubernetes-sigs#3622)
2444d4e 
The recently added Cilium conformance report is still with main version,
which was recently fixed in cilium/cilium#37671.

Relates: kubernetes-sigs#3578.

Signed-off-by: Tam Mach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikemorris mikemorris Awaiting requested review from mikemorris

@sunjayBhatia sunjayBhatia Awaiting requested review from sunjayBhatia

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

@mlavacca mlavacca Awaiting requested review from mlavacca

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

@LiorLieberman LiorLieberman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sayboras @k8s-ci-robot @LiorLieberman @robscott @mlavacca