Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features for every API in conformance tests #1891

Closed
Tracked by #1709
shaneutt opened this issue Mar 29, 2023 · 1 comment
Closed
Tracked by #1709

Features for every API in conformance tests #1891

shaneutt opened this issue Mar 29, 2023 · 1 comment
Assignees
@shaneutt
Labels
area/conformance kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-blocker MUST be completed to complete the milestone
Milestone
v0.7.0

Comments

@shaneutt
Copy link
Member

shaneutt commented Mar 29, 2023 •
edited
Loading

What would you like to be changed:

Right now we use StandardCoreFeatures as a public symbol in our conformance test suite to refer to the features which are required generically across all implementations, and StandardExtendedFeatures for the extended support level version of that. While "standard" may be correct in this case we need more expressiveness for other feature options:

  • we need to be able to indicate features which are specific to "common" APIs like GatewayClass and Gateway
  • we also should be able to indicate features that are only present in the experimental channel

Ultimately we should be in a position where no tests run implicitly, and features must be opted into to run any tests.

Why this is needed:

StandardCoreFeatures doesn't feel quite right standing alone by itself today and we expect a need for more expressiveness as we complete the work in #1709 as we already have experimental features and will have more in the future.
@shaneutt shaneutt added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/conformance labels Mar 29, 2023
@shaneutt shaneutt added this to the v1.0.0 milestone Mar 29, 2023
@shaneutt shaneutt self-assigned this Mar 29, 2023
This was referenced Mar 29, 2023
Closed
Merged
Merged
@shaneutt shaneutt changed the title Split up the StandardCoreFeatures in the conformance test suite Features for every API in conformance tests Mar 30, 2023
@shaneutt shaneutt modified the milestones: v1.0.0, v0.7.0 Mar 30, 2023
@shaneutt shaneutt added release-blocker MUST be completed to complete the milestone priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Mar 30, 2023
@shaneutt shaneutt mentioned this issue Mar 31, 2023
Merged
@shaneutt
Copy link
Member Author

shaneutt commented Apr 5, 2023

Between #1890, #1878 and #1894 we are now all set 👍

@shaneutt shaneutt closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaneutt shaneutt

Labels
area/conformance kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-blocker MUST be completed to complete the milestone
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v0.7.0
Development

No branches or pull requests
1 participant
@shaneutt