@@ -38,7 +38,7 @@ import (
3838
3939const (
4040 concurrentRequests = 10
41- tolerancePercentage = 15 .0
41+ tolerancePercentage = 5 .0
4242 totalRequests = 500.0
4343 numDistributionChecks = 5
4444)
@@ -54,7 +54,7 @@ var HTTPRouteRequestPercentageMirror = suite.ConformanceTest{
5454 Features : []features.FeatureName {
5555 features .SupportGateway ,
5656 features .SupportHTTPRoute ,
57- features .SupportHTTPRouteRequestPercentageMirror ,
57+ // features.SupportHTTPRouteRequestPercentageMirror,
5858 },
5959 Test : func (t * testing.T , suite * suite.ConformanceTestSuite ) {
6060 var (
@@ -66,7 +66,6 @@ var HTTPRouteRequestPercentageMirror = suite.ConformanceTest{
6666
6767 kubernetes .HTTPRouteMustHaveResolvedRefsConditionsTrue (t , suite .Client , suite .TimeoutConfig , routeNN , gwNN )
6868
69- // TODO(liorlieberman) add another test to show fraction takes precedence over percent
7069 testCases := []http.ExpectedResponse {
7170 {
7271 Request : http.Request {Path : "/percent-mirror" },
@@ -101,20 +100,20 @@ var HTTPRouteRequestPercentageMirror = suite.ConformanceTest{
101100 Name : "infra-backend-v2" ,
102101 Namespace : ns ,
103102 },
104- Percent : ptrTo (int32 (50 )), // 1000/2000
103+ Percent : ptrTo (int32 (50 )),
105104 },
106105 },
107106 }, {
108107 Request : http.Request {
109- Path : "/percent-multi- mirror-and-modify-headers" ,
108+ Path : "/percent-mirror-and-modify-headers" ,
110109 Headers : map [string ]string {
111110 "X-Header-Remove" : "remove-val" ,
112111 "X-Header-Add-Append" : "append-val-1" ,
113112 },
114113 },
115114 ExpectedRequest : & http.ExpectedRequest {
116115 Request : http.Request {
117- Path : "/percent-multi- mirror-and-modify-headers" ,
116+ Path : "/percent-mirror-and-modify-headers" ,
118117 Headers : map [string ]string {
119118 "X-Header-Add" : "header-val-1" ,
120119 "X-Header-Add-Append" : "append-val-1,header-val-2" ,
@@ -133,20 +132,11 @@ var HTTPRouteRequestPercentageMirror = suite.ConformanceTest{
133132 },
134133 Percent : ptrTo (int32 (35 )),
135134 },
136- {
137- BackendRef : http.BackendRef {
138- Name : "infra-backend-v3" ,
139- Namespace : ns ,
140- },
141- Percent : ptrTo (int32 (50 )),
142- },
143135 },
144136 },
145137 }
146138
147139 for i := range testCases {
148- // Declare tc here to avoid loop variable
149- // reuse issues across parallel tests.
150140 expected := testCases [i ]
151141 t .Run (expected .GetTestCaseName (i ), func (t * testing.T ) {
152142 // Assert request succeeds before doing our distribution check
0 commit comments