From 51e35c3c5637d81f4a3e5c01b94200e6a948ef4a Mon Sep 17 00:00:00 2001 From: Arko Dasgupta Date: Thu, 26 Oct 2023 19:21:21 -0700 Subject: [PATCH] Fix bugs in GatewayWithAttachedRoutes * Set status to `False` for `notAccepted` Route condition * Remove `Accepted` condition from `status.listeners[0].conditions` since it is not mandatory for the `Accepted` to be set. In this case the `ResolvedRefs=False` due to `InvalidCertificateRef` so an implementation may choose to not generate any listener config Signed-off-by: Arko Dasgupta --- conformance/tests/gateway-with-attached-routes.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/conformance/tests/gateway-with-attached-routes.go b/conformance/tests/gateway-with-attached-routes.go index feb8c404e8..352540ec16 100644 --- a/conformance/tests/gateway-with-attached-routes.go +++ b/conformance/tests/gateway-with-attached-routes.go @@ -101,11 +101,6 @@ var GatewayWithAttachedRoutes = suite.ConformanceTest{ Kind: v1.Kind("HTTPRoute"), }}, Conditions: []metav1.Condition{ - { - Type: string(v1.ListenerConditionAccepted), - Status: metav1.ConditionTrue, - Reason: "", // any reason - }, { Type: string(v1.ListenerConditionProgrammed), Status: metav1.ConditionFalse, @@ -125,7 +120,7 @@ var GatewayWithAttachedRoutes = suite.ConformanceTest{ hrouteNN := types.NamespacedName{Name: "http-route-4", Namespace: "gateway-conformance-infra"} notAccepted := metav1.Condition{ Type: string(v1.RouteConditionAccepted), - Status: metav1.ConditionTrue, + Status: metav1.ConditionFalse, Reason: "", // any reason } unresolved := metav1.Condition{