added context argument to scheduling profile picker #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since this is a custom logic, getting context as argument can be useful. specific in my case I want to use contextual logging Signed-off-by: Nir Rozenbaum <[email protected]>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
Contributor
Author
|
/assign @ahg-g |
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
elevran
approved these changes
Jun 5, 2025
pkg/epp/scheduling/framework/plugins/profile-picker/all_profiles_picker.go
Outdated
Show resolved
Hide resolved
Contributor
|
@elevran: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…es_picker.go Co-authored-by: Etai Lev Ran <[email protected]>
k8s-ci-robot
removed
the
lgtm
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, elevran, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
shmuelk
pushed a commit
to shmuelk/gateway-api-inference-extension
that referenced
this pull request
Jun 9, 2025
) * added context argument to scheduling profile picker since this is a custom logic, getting context as argument can be useful. specific in my case I want to use contextual logging Signed-off-by: Nir Rozenbaum <[email protected]> * Update pkg/epp/scheduling/framework/plugins/profile-picker/all_profiles_picker.go Co-authored-by: Etai Lev Ran <[email protected]> --------- Signed-off-by: Nir Rozenbaum <[email protected]> Co-authored-by: Abdullah Gharaibeh <[email protected]> Co-authored-by: Etai Lev Ran <[email protected]>
rlakhtakia
pushed a commit
to rlakhtakia/gateway-api-inference-extension
that referenced
this pull request
Jun 11, 2025
) * added context argument to scheduling profile picker since this is a custom logic, getting context as argument can be useful. specific in my case I want to use contextual logging Signed-off-by: Nir Rozenbaum <[email protected]> * Update pkg/epp/scheduling/framework/plugins/profile-picker/all_profiles_picker.go Co-authored-by: Etai Lev Ran <[email protected]> --------- Signed-off-by: Nir Rozenbaum <[email protected]> Co-authored-by: Abdullah Gharaibeh <[email protected]> Co-authored-by: Etai Lev Ran <[email protected]>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since this is a custom logic, getting context as argument can be useful.
specific in my case I want to use contextual logging.
This was missed from the initial version that was merged.