Make k8s access explicitly read only #1101
Conversation
This is more aligned with the actual use abd prevents accidental mutation of k8s objects. Signed-off-by: Etai Lev Ran <[email protected]>
While this is more aligned with the intent, in some cases the hepler calls unto gateway API code which is expecting a full fledged client. In those cases, the original parameter type has been retained (instead of type casting in the call to Gateway API code) Signed-off-by: Etai Lev Ran <[email protected]>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @elevran. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
this lgtm. |
|
Great call /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elevran, kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This change should not impact conformance, if it does, something is not right :) |
yup, I was verifying 🙂 |
* Repleace client.Client with client.Reader This is more aligned with the actual use abd prevents accidental mutation of k8s objects. Signed-off-by: Etai Lev Ran <[email protected]> * Replace client.Client with client.Reader While this is more aligned with the intent, in some cases the hepler calls unto gateway API code which is expecting a full fledged client. In those cases, the original parameter type has been retained (instead of type casting in the call to Gateway API code) Signed-off-by: Etai Lev Ran <[email protected]> --------- Signed-off-by: Etai Lev Ran <[email protected]>
* Repleace client.Client with client.Reader This is more aligned with the actual use abd prevents accidental mutation of k8s objects. Signed-off-by: Etai Lev Ran <[email protected]> * Replace client.Client with client.Reader While this is more aligned with the intent, in some cases the hepler calls unto gateway API code which is expecting a full fledged client. In those cases, the original parameter type has been retained (instead of type casting in the call to Gateway API code) Signed-off-by: Etai Lev Ran <[email protected]> --------- Signed-off-by: Etai Lev Ran <[email protected]>
5 participants
Changed most occurrences of
client.Clienttoclient.Readerwhich is aligned with usage and prevents accidental mutation of API objects.Note
Some conformance tests are kept with the original
client.Clientparameter as they internally call Gateway API functions which expect a full fledged client.If preferred, it might be possible to change the API to accept a Reader and then type assert before calling the Gateway API with a
client.Client.This is in response to comment on #1093