If a picker is missing, always add a MaxScorePicker

Signed-off-by: Shmuel Kallner <[email protected]>

Author: shmuelk

pkg/epp/common/config/loader/configloader.go

@@ -68,7 +68,6 @@ func LoadSchedulerConfig(configProfiles []configapi.SchedulingProfile, handle pl
 	for _, namedProfile := range configProfiles {
 		profile := framework.NewSchedulerProfile()
 		pickerAdded := false
-		scorerAdded := false
 		for _, plugin := range namedProfile.Plugins {
 			referencedPlugin := handle.Plugin(plugin.PluginRef)
 			if scorer, ok := referencedPlugin.(framework.Scorer); ok {
@@ -78,7 +77,6 @@ func LoadSchedulerConfig(configProfiles []configapi.SchedulingProfile, handle pl
 					weight = *plugin.Weight
 				}
 				referencedPlugin = framework.NewWeightedScorer(scorer, weight)
-				scorerAdded = true
 			}
 			if _, ok := referencedPlugin.(framework.Picker); ok {
 				pickerAdded = true
@@ -89,13 +87,7 @@ func LoadSchedulerConfig(configProfiles []configapi.SchedulingProfile, handle pl
 		}
 		if !pickerAdded {
 			// There isn't a picker in this profile, add one
-			var thePicker framework.Picker
-			if scorerAdded {
-				thePicker = picker.NewMaxScorePicker(picker.DefaultMaxNumOfEndpoints)
-			} else {
-				thePicker = picker.NewRandomPicker(picker.DefaultMaxNumOfEndpoints)
-			}
-
+			thePicker := picker.NewMaxScorePicker(picker.DefaultMaxNumOfEndpoints)
 			if err := profile.AddPlugins(thePicker); err != nil {
 				return nil, fmt.Errorf("failed to load scheduler config - %w", err)
 			}

pkg/epp/common/config/loader/configloader_test.go

@@ -265,11 +265,6 @@ func TestLoadSchedulerConfig(t *testing.T) {
 			configText: successWithNoProfileHandlersText,
 			wantErr:    false,
 		},
-		{
-			name:       "successWithNoPicker",
-			configText: successWithNoPickerText,
-			wantErr:    false,
-		},
 		{
 			name:       "errorBadPluginJson",
 			configText: errorBadPluginJsonText,
@@ -717,23 +712,6 @@ schedulingProfiles:
   - pluginRef: maxScore
 `
 
-// valid configuration using default profile handler
-//
-//nolint:dupword
-const successWithNoPickerText = `
-apiVersion: inference.networking.x-k8s.io/v1alpha1
-kind: EndpointPickerConfig
-plugins:
-- name: lowQueueFilter
-  type: low-queue-filter
-  parameters:
-    threshold: 10
-schedulingProfiles:
-- name: default
-  plugins:
-  - pluginRef: lowQueueFilter
-`
-
 // invalid parameter configuration for plugin (string passed, in expected)
 //
 //nolint:dupword

site-src/guides/epp-configuration/config-text.md

@@ -19,9 +19,8 @@ will be used for a particular request. A Profile Handler must be specified, unle
 contains one profile, in which case the `SingleProfileHandler` will be used.
 
 In addition, the set of instantiated plugins can also include a picker, which chooses the actual pod to which
-the request is scheduled after filtering and scoring. If one is not referenced in a SchedulingProfile, one
-will be added. The picker added depends on whether or not scorers were referenced in the SchedulingProfile
-in question.
+the request is scheduled after filtering and scoring. If one is not referenced in a SchedulingProfile, an
+instance of `MaxScorePicker` will be added to the SchedulingProfile in question.
 
 It should be noted that while the configuration text looks like a Kubernetes Custom Resource, it is
 **NOT** a Kubernetes Custom Resource. Kubernetes infrastructure is used to load the configuration