Remove Type() and Name() from Plugin interface

elevran · elevran · commit 634b828e4b9d · 2025-06-30T16:20:07.000+03:00
Signed-off-by: Etai Lev Ran &lt;elevran@gmail.com&gt;
diff --git a/conformance/testing-epp/plugins/filter/request_header_based_filter.go b/conformance/testing-epp/plugins/filter/request_header_based_filter.go
@@ -40,7 +40,7 @@ var _ framework.Filter = &HeaderBasedTestingFilter{}
 // This should only be used for testing purposes.
 func NewHeaderBasedTestingFilter() *HeaderBasedTestingFilter {
 	return &HeaderBasedTestingFilter{
-		TypedName: plugins.TypedName{PluginType: "header-based-testing", PluginName: "header-based-testing-filter"},
+		TypedName: plugins.TypedName{Type: "header-based-testing", Name: "header-based-testing-filter"},
 	}
 }
 
diff --git a/pkg/epp/common/config/loader/configloader_test.go b/pkg/epp/common/config/loader/configloader_test.go
@@ -561,7 +561,7 @@ type test1 struct {
 
 func newTest1() *test1 {
 	return &test1{
-		TypedName: plugins.TypedName{PluginType: test1Type, PluginName: "test-1"},
+		TypedName: plugins.TypedName{Type: test1Type, Name: "test-1"},
 	}
 }
 
@@ -580,7 +580,7 @@ type test2 struct {
 
 func newTest2() *test2 {
 	return &test2{
-		TypedName: plugins.TypedName{PluginType: test2Type, PluginName: "test-2"},
+		TypedName: plugins.TypedName{Type: test2Type, Name: "test-2"},
 	}
 }
 
@@ -599,7 +599,7 @@ type testPicker struct {
 
 func newTestPicker() *testPicker {
 	return &testPicker{
-		TypedName: plugins.TypedName{PluginType: testPickerType, PluginName: "test-picker"},
+		TypedName: plugins.TypedName{Type: testPickerType, Name: "test-picker"},
 	}
 }
 
@@ -616,7 +616,7 @@ type testProfileHandler struct {
 
 func newTestProfileHandler() *testProfileHandler {
 	return &testProfileHandler{
-		TypedName: plugins.TypedName{PluginType: testProfileHandlerType, PluginName: "test-profile-handler"},
+		TypedName: plugins.TypedName{Type: testProfileHandlerType, Name: "test-profile-handler"},
 	}
 }
 
diff --git a/pkg/epp/plugins/plugins.go b/pkg/epp/plugins/plugins.go
@@ -24,10 +24,6 @@ import (
 // Plugin defines the interface for a plugin.
 // This interface should be embedded in all plugins across the code.
 type Plugin interface {
-	// Type returns the type of the plugin.
-	Type() string
-	// Name returns the name of this plugin instance.
-	Name() string
 	// GetTypedName returns the type and name of this plugin instance.
 	GetTypedName() TypedName
 }
diff --git a/pkg/epp/plugins/typedname.go b/pkg/epp/plugins/typedname.go
@@ -21,18 +21,10 @@ package plugins
 // It implements the Plugin interface and can be embedded in
 // plugins across the code to reduce boilerplate.
 type TypedName struct {
-	PluginType string
-	PluginName string
-}
-
-// Type returns the type of the plugin.
-func (tn *TypedName) Type() string {
-	return tn.PluginType
-}
-
-// Name returns the name of this plugin instance.
-func (tn *TypedName) Name() string {
-	return tn.PluginName
+	// Type returns the type of the plugin.
+	Type string
+	// Name returns the name of this plugin instance.
+	Name string
 }
 
 const (
@@ -42,7 +34,7 @@ const (
 // String returns the type and name rendered as
 // "<type>/<name>".
 func (tn *TypedName) String() string {
-	return tn.PluginType + Separator + tn.PluginName
+	return tn.Type + Separator + tn.Name
 }
 
 func (tn *TypedName) GetTypedName() TypedName {
diff --git a/pkg/epp/requestcontrol/director.go b/pkg/epp/requestcontrol/director.go
@@ -312,18 +312,18 @@ func RandomWeightedDraw(logger logr.Logger, model *v1alpha2.InferenceModel, seed
 func (d *Director) runPreRequestPlugins(ctx context.Context, request *schedulingtypes.LLMRequest, schedulingResult *schedulingtypes.SchedulingResult,
 	targetPort int) {
 	for _, plugin := range d.preRequestPlugins {
-		log.FromContext(ctx).V(logutil.DEBUG).Info("Running pre-request plugin", "plugin", plugin.Type())
+		log.FromContext(ctx).V(logutil.DEBUG).Info("Running pre-request plugin", "plugin", plugin.GetTypedName().Type)
 		before := time.Now()
 		plugin.PreRequest(ctx, request, schedulingResult, targetPort)
-		metrics.RecordRequestControlPluginProcessingLatency(PreRequestPluginType, plugin.Type(), time.Since(before))
+		metrics.RecordRequestControlPluginProcessingLatency(PreRequestPluginType, plugin.GetTypedName().Type, time.Since(before))
 	}
 }
 
 func (d *Director) runPostResponsePlugins(ctx context.Context, request *schedulingtypes.LLMRequest, response *Response, targetPod *backend.Pod) {
 	for _, plugin := range d.postResponsePlugins {
-		log.FromContext(ctx).V(logutil.DEBUG).Info("Running post-response plugin", "plugin", plugin.Type())
+		log.FromContext(ctx).V(logutil.DEBUG).Info("Running post-response plugin", "plugin", plugin.GetTypedName().Type)
 		before := time.Now()
 		plugin.PostResponse(ctx, request, response, targetPod)
-		metrics.RecordRequestControlPluginProcessingLatency(PostResponsePluginType, plugin.Type(), time.Since(before))
+		metrics.RecordRequestControlPluginProcessingLatency(PostResponsePluginType, plugin.GetTypedName().Type, time.Since(before))
 	}
 }
diff --git a/pkg/epp/requestcontrol/director_test.go b/pkg/epp/requestcontrol/director_test.go
@@ -702,7 +702,7 @@ type testPostResponse struct {
 
 func newTestPostResponse(name string) *testPostResponse {
 	return &testPostResponse{
-		TypedName: plugins.TypedName{PluginType: testPostResponseType, PluginName: name},
+		TypedName: plugins.TypedName{Type: testPostResponseType, Name: name},
 	}
 }
 
diff --git a/pkg/epp/scheduling/framework/plugins/filter/decision_tree_filter.go b/pkg/epp/scheduling/framework/plugins/filter/decision_tree_filter.go
@@ -133,27 +133,14 @@ func loadDecisionTreeEntry(entry *decisionTreeFilterEntry, handle plugins.Handle
 	return nil, errors.New("either pluginRef or decisionTree must be specified")
 }
 
-// Type returns the type of the filter.
-func (f *DecisionTreeFilter) Type() string {
-	if f == nil {
-		return "nil"
-	}
-	return f.Current.Type()
-}
-
-// Name returns the name of the filter.
-func (f *DecisionTreeFilter) Name() string {
-	if f == nil {
-		return ""
-	}
-	return f.Current.Name()
-}
-
 func (f *DecisionTreeFilter) GetTypedName() plugins.TypedName {
-	return plugins.TypedName{
-		PluginType: f.Type(),
-		PluginName: f.Name(),
+	if f == nil {
+		// TODO: this keeps the previous behavior ("nil"/"") - not sure
+		// why done this way.
+		// Change to empty TypedName or some more meaningful values?
+		return plugins.TypedName{Type: "nil", Name: ""}
 	}
+	return f.Current.GetTypedName()
 }
 
 // Filter filters out pods that doesn't meet the filter criteria.
@@ -170,7 +157,7 @@ func (f *DecisionTreeFilter) Filter(ctx context.Context, cycleState *types.Cycle
 		if f.NextOnSuccess != nil {
 			next = f.NextOnSuccess
 		}
-		loggerTrace.Info("Filter succeeded", "filter", f.Type(), "next", next.Type(), "filteredPodCount", len(filteredPod))
+		loggerTrace.Info("Filter succeeded", "filter", f.GetTypedName(), "next", next.GetTypedName(), "filteredPodCount", len(filteredPod))
 		// On success, pass the filtered result to the next filter.
 		return next.Filter(ctx, cycleState, request, filteredPod)
 	} else {
@@ -181,7 +168,7 @@ func (f *DecisionTreeFilter) Filter(ctx context.Context, cycleState *types.Cycle
 		if f.NextOnFailure != nil {
 			next = f.NextOnFailure
 		}
-		loggerTrace.Info("Filter failed", "filter", f.Type(), "next", next.Type())
+		loggerTrace.Info("Filter failed", "filter", f.GetTypedName(), "next", next.GetTypedName())
 		// On failure, pass the initial set of pods to the next filter.
 		return next.Filter(ctx, cycleState, request, pods)
 	}
diff --git a/pkg/epp/scheduling/framework/plugins/filter/filter_test.go b/pkg/epp/scheduling/framework/plugins/filter/filter_test.go
@@ -45,7 +45,7 @@ type filterAll struct {
 
 func newFilterAll() *filterAll {
 	return &filterAll{
-		TypedName: plugins.TypedName{PluginType: "filter-all", PluginName: "test-all"},
+		TypedName: plugins.TypedName{Type: "filter-all", Name: "test-all"},
 	}
 }
 
diff --git a/pkg/epp/scheduling/framework/plugins/filter/least_kvcache_filter.go b/pkg/epp/scheduling/framework/plugins/filter/least_kvcache_filter.go
@@ -41,7 +41,7 @@ func LeastKVCacheFilterFactory(name string, _ json.RawMessage, _ plugins.Handle)
 // NewLeastKVCacheFilter initializes a new LeastKVCacheFilter and returns its pointer.
 func NewLeastKVCacheFilter() *LeastKVCacheFilter {
 	return &LeastKVCacheFilter{
-		TypedName: plugins.TypedName{PluginType: LeastKVCacheFilterType, PluginName: LeastKVCacheFilterType},
+		TypedName: plugins.TypedName{Type: LeastKVCacheFilterType, Name: LeastKVCacheFilterType},
 	}
 }
 
@@ -56,7 +56,7 @@ type LeastKVCacheFilter struct {
 
 // WithName sets the name of the filter.
 func (f *LeastKVCacheFilter) WithName(name string) *LeastKVCacheFilter {
-	f.PluginName = name
+	f.Name = name
 	return f
 }
 
diff --git a/pkg/epp/scheduling/framework/plugins/filter/least_queue_filter.go b/pkg/epp/scheduling/framework/plugins/filter/least_queue_filter.go
@@ -41,7 +41,7 @@ func LeastQueueFilterFactory(name string, _ json.RawMessage, _ plugins.Handle) (
 // NewLeastQueueFilter initializes a new LeastQueueFilter and returns its pointer.
 func NewLeastQueueFilter() *LeastQueueFilter {
 	return &LeastQueueFilter{
-		TypedName: plugins.TypedName{PluginType: LeastQueueFilterType, PluginName: LeastQueueFilterType},
+		TypedName: plugins.TypedName{Type: LeastQueueFilterType, Name: LeastQueueFilterType},
 	}
 }
 
@@ -56,7 +56,7 @@ type LeastQueueFilter struct {
 
 // WithName sets the name of the filter.
 func (f *LeastQueueFilter) WithName(name string) *LeastQueueFilter {
-	f.PluginName = name
+	f.Name = name
 	return f
 }
 
diff --git a/pkg/epp/scheduling/framework/plugins/filter/lora_affinity_filter.go b/pkg/epp/scheduling/framework/plugins/filter/lora_affinity_filter.go
@@ -52,7 +52,7 @@ func LoraAffinityFilterFactory(name string, rawParameters json.RawMessage, _ plu
 // NewLoraAffinityFilter initializes a new LoraAffinityFilter and returns its pointer.
 func NewLoraAffinityFilter(threshold float64) *LoraAffinityFilter {
 	return &LoraAffinityFilter{
-		TypedName:             plugins.TypedName{PluginType: LoraAffinityFilterType, PluginName: LoraAffinityFilterType},
+		TypedName:             plugins.TypedName{Type: LoraAffinityFilterType, Name: LoraAffinityFilterType},
 		loraAffinityThreshold: threshold,
 	}
 }
@@ -71,7 +71,7 @@ type LoraAffinityFilter struct {
 
 // WithName sets the type of the filter.
 func (f *LoraAffinityFilter) WithName(name string) *LoraAffinityFilter {
-	f.PluginName = name
+	f.Name = name
 	return f
 }
 
diff --git a/pkg/epp/scheduling/framework/plugins/filter/low_queue_filter.go b/pkg/epp/scheduling/framework/plugins/filter/low_queue_filter.go
@@ -52,7 +52,7 @@ func LowQueueFilterFactory(name string, rawParameters json.RawMessage, _ plugins
 // NewLowQueueFilter initializes a new LowQueueFilter and returns its pointer.
 func NewLowQueueFilter(threshold int) *LowQueueFilter {
 	return &LowQueueFilter{
-		TypedName:             plugins.TypedName{PluginType: LowQueueFilterType, PluginName: LowQueueFilterType},
+		TypedName:             plugins.TypedName{Type: LowQueueFilterType, Name: LowQueueFilterType},
 		queueingThresholdLoRA: threshold,
 	}
 }
@@ -65,7 +65,7 @@ type LowQueueFilter struct {
 
 // WithName sets the name of the filter.
 func (f *LowQueueFilter) WithName(name string) *LowQueueFilter {
-	f.PluginName = name
+	f.Name = name
 	return f
 }
 
diff --git a/pkg/epp/scheduling/framework/plugins/multi/prefix/plugin.go b/pkg/epp/scheduling/framework/plugins/multi/prefix/plugin.go
@@ -144,15 +144,15 @@ func New(config Config) *Plugin {
 	}
 
 	return &Plugin{
-		TypedName: plugins.TypedName{PluginType: PrefixCachePluginType, PluginName: PrefixCachePluginType},
+		TypedName: plugins.TypedName{Type: PrefixCachePluginType, Name: PrefixCachePluginType},
 		Config:    config,
 		indexer:   newIndexer(capacity),
 	}
 }
 
 // WithName sets the name of the plugin.
 func (m *Plugin) WithName(name string) *Plugin {
-	m.PluginName = name
+	m.Name = name
 	return m
 }
 
@@ -166,7 +166,7 @@ func (m *Plugin) Score(ctx context.Context, cycleState *types.CycleState, reques
 		PrefixCacheServers: m.matchLongestPrefix(ctx, hashes),
 	}
 
-	cycleState.Write(types.StateKey(m.Type()), state)
+	cycleState.Write(types.StateKey(m.GetTypedName().Type), state)
 	loggerTrace.Info(fmt.Sprintf("cached servers: %+v", state.PrefixCacheServers), "hashes", state.PrefixHashes)
 	// calculate the scores of pods
 	scores := make(map[types.Pod]float64, len(pods))
diff --git a/pkg/epp/scheduling/framework/plugins/picker/max_score_picker.go b/pkg/epp/scheduling/framework/plugins/picker/max_score_picker.go
@@ -43,7 +43,7 @@ func MaxScorePickerFactory(name string, _ json.RawMessage, _ plugins.Handle) (pl
 // NewMaxScorePicker initializes a new MaxScorePicker and returns its pointer.
 func NewMaxScorePicker() *MaxScorePicker {
 	return &MaxScorePicker{
-		TypedName: plugins.TypedName{PluginType: MaxScorePickerType, PluginName: MaxScorePickerType},
+		TypedName: plugins.TypedName{Type: MaxScorePickerType, Name: MaxScorePickerType},
 		random:    NewRandomPicker(),
 	}
 }
@@ -56,7 +56,7 @@ type MaxScorePicker struct {
 
 // WithName sets the picker's name
 func (p *MaxScorePicker) WithName(name string) *MaxScorePicker {
-	p.PluginName = name
+	p.Name = name
 	return p
 }
 
diff --git a/pkg/epp/scheduling/framework/plugins/picker/random_picker.go b/pkg/epp/scheduling/framework/plugins/picker/random_picker.go
@@ -45,7 +45,7 @@ func RandomPickerFactory(name string, _ json.RawMessage, _ plugins.Handle) (plug
 // NewRandomPicker initializes a new RandomPicker and returns its pointer.
 func NewRandomPicker() *RandomPicker {
 	return &RandomPicker{
-		TypedName: plugins.TypedName{PluginType: RandomPickerType, PluginName: RandomPickerType},
+		TypedName: plugins.TypedName{Type: RandomPickerType, Name: RandomPickerType},
 	}
 }
 
@@ -56,7 +56,7 @@ type RandomPicker struct {
 
 // WithName sets the name of the picker.
 func (p *RandomPicker) WithName(name string) *RandomPicker {
-	p.PluginName = name
+	p.Name = name
 	return p
 }
 
diff --git a/pkg/epp/scheduling/framework/plugins/profile/single_profile_handler.go b/pkg/epp/scheduling/framework/plugins/profile/single_profile_handler.go
@@ -42,7 +42,7 @@ func SingleProfileHandlerFactory(name string, _ json.RawMessage, _ plugins.Handl
 // NewSingleProfileHandler initializes a new SingleProfileHandler and returns its pointer.
 func NewSingleProfileHandler() *SingleProfileHandler {
 	return &SingleProfileHandler{
-		TypedName: plugins.TypedName{PluginType: SingleProfileHandlerType, PluginName: SingleProfileHandlerType},
+		TypedName: plugins.TypedName{Type: SingleProfileHandlerType, Name: SingleProfileHandlerType},
 	}
 }
 
@@ -53,7 +53,7 @@ type SingleProfileHandler struct {
 
 // WithName sets the name of the profile handler.
 func (h *SingleProfileHandler) WithName(name string) *SingleProfileHandler {
-	h.PluginName = name
+	h.Name = name
 	return h
 }
 
diff --git a/pkg/epp/scheduling/framework/plugins/scorer/kvcache.go b/pkg/epp/scheduling/framework/plugins/scorer/kvcache.go
@@ -41,7 +41,7 @@ func KvCacheScorerFactory(name string, _ json.RawMessage, _ plugins.Handle) (plu
 // NewKVCacheScorer initializes a new KVCacheScorer and returns its pointer.
 func NewKVCacheScorer() *KVCacheScorer {
 	return &KVCacheScorer{
-		TypedName: plugins.TypedName{PluginType: KvCacheScorerType, PluginName: KvCacheScorerType},
+		TypedName: plugins.TypedName{Type: KvCacheScorerType, Name: KvCacheScorerType},
 	}
 }
 
@@ -52,7 +52,7 @@ type KVCacheScorer struct {
 
 // WithName sets the name of the scorer.
 func (s *KVCacheScorer) WithName(name string) *KVCacheScorer {
-	s.PluginName = name
+	s.Name = name
 	return s
 }
 
diff --git a/pkg/epp/scheduling/framework/plugins/scorer/queue.go b/pkg/epp/scheduling/framework/plugins/scorer/queue.go
@@ -42,7 +42,7 @@ func QueueScorerFactory(name string, _ json.RawMessage, _ plugins.Handle) (plugi
 // NewQueueScorer initializes a new QueueScorer and returns its pointer.
 func NewQueueScorer() *QueueScorer {
 	return &QueueScorer{
-		TypedName: plugins.TypedName{PluginType: QueueScorerType, PluginName: QueueScorerType},
+		TypedName: plugins.TypedName{Type: QueueScorerType, Name: QueueScorerType},
 	}
 }
 
@@ -54,7 +54,7 @@ type QueueScorer struct {
 
 // WithName sets the name of the scorer.
 func (s *QueueScorer) WithName(name string) *QueueScorer {
-	s.PluginName = name
+	s.Name = name
 	return s
 }
 
diff --git a/pkg/epp/scheduling/framework/scheduler_profile.go b/pkg/epp/scheduling/framework/scheduler_profile.go
diff --git a/pkg/epp/scheduling/framework/scheduler_profile_test.go b/pkg/epp/scheduling/framework/scheduler_profile_test.go
diff --git a/pkg/epp/scheduling/scheduler.go b/pkg/epp/scheduling/scheduler.go

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ var _ framework.Filter = &HeaderBasedTestingFilter{}`
`40`	`40`	`// This should only be used for testing purposes.`
`41`	`41`	`func NewHeaderBasedTestingFilter() *HeaderBasedTestingFilter {`
`42`	`42`	`return &HeaderBasedTestingFilter{`
`43`		`- TypedName: plugins.TypedName{PluginType: "header-based-testing", PluginName: "header-based-testing-filter"},`
	`43`	`+ TypedName: plugins.TypedName{Type: "header-based-testing", Name: "header-based-testing-filter"},`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`
Original file line number	Diff line number	Diff line change
`@@ -561,7 +561,7 @@ type test1 struct {`
`561`	`561`
`562`	`562`	`func newTest1() *test1 {`
`563`	`563`	`return &test1{`
`564`		`- TypedName: plugins.TypedName{PluginType: test1Type, PluginName: "test-1"},`
	`564`	`+ TypedName: plugins.TypedName{Type: test1Type, Name: "test-1"},`
`565`	`565`	`}`
`566`	`566`	`}`
`567`	`567`
`@@ -580,7 +580,7 @@ type test2 struct {`
`580`	`580`
`581`	`581`	`func newTest2() *test2 {`
`582`	`582`	`return &test2{`
`583`		`- TypedName: plugins.TypedName{PluginType: test2Type, PluginName: "test-2"},`
	`583`	`+ TypedName: plugins.TypedName{Type: test2Type, Name: "test-2"},`
`584`	`584`	`}`
`585`	`585`	`}`
`586`	`586`
`@@ -599,7 +599,7 @@ type testPicker struct {`
`599`	`599`
`600`	`600`	`func newTestPicker() *testPicker {`
`601`	`601`	`return &testPicker{`
`602`		`- TypedName: plugins.TypedName{PluginType: testPickerType, PluginName: "test-picker"},`
	`602`	`+ TypedName: plugins.TypedName{Type: testPickerType, Name: "test-picker"},`
`603`	`603`	`}`
`604`	`604`	`}`
`605`	`605`
`@@ -616,7 +616,7 @@ type testProfileHandler struct {`
`616`	`616`
`617`	`617`	`func newTestProfileHandler() *testProfileHandler {`
`618`	`618`	`return &testProfileHandler{`
`619`		`- TypedName: plugins.TypedName{PluginType: testProfileHandlerType, PluginName: "test-profile-handler"},`
	`619`	`+ TypedName: plugins.TypedName{Type: testProfileHandlerType, Name: "test-profile-handler"},`
`620`	`620`	`}`
`621`	`621`	`}`
`622`	`622`
Original file line number	Diff line number	Diff line change
`@@ -312,18 +312,18 @@ func RandomWeightedDraw(logger logr.Logger, model *v1alpha2.InferenceModel, seed`
`312`	`312`	`func (d Director) runPreRequestPlugins(ctx context.Context, request schedulingtypes.LLMRequest, schedulingResult *schedulingtypes.SchedulingResult,`
`313`	`313`	`targetPort int) {`
`314`	`314`	`for _, plugin := range d.preRequestPlugins {`
`315`		`- log.FromContext(ctx).V(logutil.DEBUG).Info("Running pre-request plugin", "plugin", plugin.Type())`
	`315`	`+ log.FromContext(ctx).V(logutil.DEBUG).Info("Running pre-request plugin", "plugin", plugin.GetTypedName().Type)`
`316`	`316`	`before := time.Now()`
`317`	`317`	`plugin.PreRequest(ctx, request, schedulingResult, targetPort)`
`318`		`- metrics.RecordRequestControlPluginProcessingLatency(PreRequestPluginType, plugin.Type(), time.Since(before))`
	`318`	`+ metrics.RecordRequestControlPluginProcessingLatency(PreRequestPluginType, plugin.GetTypedName().Type, time.Since(before))`
`319`	`319`	`}`
`320`	`320`	`}`
`321`	`321`
`322`	`322`	`func (d Director) runPostResponsePlugins(ctx context.Context, request schedulingtypes.LLMRequest, response Response, targetPod backend.Pod) {`
`323`	`323`	`for _, plugin := range d.postResponsePlugins {`
`324`		`- log.FromContext(ctx).V(logutil.DEBUG).Info("Running post-response plugin", "plugin", plugin.Type())`
	`324`	`+ log.FromContext(ctx).V(logutil.DEBUG).Info("Running post-response plugin", "plugin", plugin.GetTypedName().Type)`
`325`	`325`	`before := time.Now()`
`326`	`326`	`plugin.PostResponse(ctx, request, response, targetPod)`
`327`		`- metrics.RecordRequestControlPluginProcessingLatency(PostResponsePluginType, plugin.Type(), time.Since(before))`
	`327`	`+ metrics.RecordRequestControlPluginProcessingLatency(PostResponsePluginType, plugin.GetTypedName().Type, time.Since(before))`
`328`	`328`	`}`
`329`	`329`	`}`
Original file line number	Diff line number	Diff line change
`@@ -702,7 +702,7 @@ type testPostResponse struct {`
`702`	`702`
`703`	`703`	`func newTestPostResponse(name string) *testPostResponse {`
`704`	`704`	`return &testPostResponse{`
`705`		`- TypedName: plugins.TypedName{PluginType: testPostResponseType, PluginName: name},`
	`705`	`+ TypedName: plugins.TypedName{Type: testPostResponseType, Name: name},`
`706`	`706`	`}`
`707`	`707`	`}`
`708`	`708`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ type filterAll struct {`
`45`	`45`
`46`	`46`	`func newFilterAll() *filterAll {`
`47`	`47`	`return &filterAll{`
`48`		`- TypedName: plugins.TypedName{PluginType: "filter-all", PluginName: "test-all"},`
	`48`	`+ TypedName: plugins.TypedName{Type: "filter-all", Name: "test-all"},`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ func LeastKVCacheFilterFactory(name string, _ json.RawMessage, _ plugins.Handle)`
`41`	`41`	`// NewLeastKVCacheFilter initializes a new LeastKVCacheFilter and returns its pointer.`
`42`	`42`	`func NewLeastKVCacheFilter() *LeastKVCacheFilter {`
`43`	`43`	`return &LeastKVCacheFilter{`
`44`		`- TypedName: plugins.TypedName{PluginType: LeastKVCacheFilterType, PluginName: LeastKVCacheFilterType},`
	`44`	`+ TypedName: plugins.TypedName{Type: LeastKVCacheFilterType, Name: LeastKVCacheFilterType},`
`45`	`45`	`}`
`46`	`46`	`}`
`47`	`47`
`@@ -56,7 +56,7 @@ type LeastKVCacheFilter struct {`
`56`	`56`
`57`	`57`	`// WithName sets the name of the filter.`
`58`	`58`	`func (f LeastKVCacheFilter) WithName(name string) LeastKVCacheFilter {`
`59`		`- f.PluginName = name`
	`59`	`+ f.Name = name`
`60`	`60`	`return f`
`61`	`61`	`}`
`62`	`62`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ func LeastQueueFilterFactory(name string, _ json.RawMessage, _ plugins.Handle) (`
`41`	`41`	`// NewLeastQueueFilter initializes a new LeastQueueFilter and returns its pointer.`
`42`	`42`	`func NewLeastQueueFilter() *LeastQueueFilter {`
`43`	`43`	`return &LeastQueueFilter{`
`44`		`- TypedName: plugins.TypedName{PluginType: LeastQueueFilterType, PluginName: LeastQueueFilterType},`
	`44`	`+ TypedName: plugins.TypedName{Type: LeastQueueFilterType, Name: LeastQueueFilterType},`
`45`	`45`	`}`
`46`	`46`	`}`
`47`	`47`
`@@ -56,7 +56,7 @@ type LeastQueueFilter struct {`
`56`	`56`
`57`	`57`	`// WithName sets the name of the filter.`
`58`	`58`	`func (f LeastQueueFilter) WithName(name string) LeastQueueFilter {`
`59`		`- f.PluginName = name`
	`59`	`+ f.Name = name`
`60`	`60`	`return f`
`61`	`61`	`}`
`62`	`62`