feedback updates

Author: kfswain

api/inferencemodel_types.go

@@ -67,14 +67,14 @@ type InferenceModelSpec struct {
 	// This can be done by specifying a target model and setting the weight to zero,
 	// an error will be returned specifying that no valid target model is found.
 	//
-	// +kubebuilder:validation:MaxLength=253
+	// +kubebuilder:validation:MaxLength=256
 	// +kubebuilder:validation:Required
 	ModelName string `json:"modelName"`
 
 	// Criticality defines how important it is to serve the model compared to other models referencing the same pool.
+	// The lack of defaulting is intentional, the behavior of not setting criticality future-proofs the API without complicating.
 	//
 	// +optional
-	// +kubebuilder:default="Default"
 	Criticality *Criticality `json:"criticality,omitempty"`
 
 	// TargetModels allow multiple versions of a model for traffic splitting.
@@ -196,7 +196,7 @@ const (
 	ModelReasonNameInUse InferenceModelConditionReason = "ModelNameInUse"
 
 	// This reason is the initial state, and indicates that the controller has not yet reconciled the InferenceModel.
-	PoolReasonPending InferenceModelConditionReason = "Pending"
+	ModelReasonPending InferenceModelConditionReason = "Pending"
 )
 
 func init() {

api/inferencepool_types.go

@@ -45,9 +45,7 @@ type InferencePoolList struct {
 // InferencePoolSpec defines the desired state of InferencePool
 type InferencePoolSpec struct {
 	// Selector defines a map of label to watch model server pods
-	// that should be included in the InferencePool. ModelServers should not
-	// be with any other Service or InferencePool, that behavior is not supported
-	// and will result in sub-optimal utilization.
+	// that should be included in the InferencePool.
 	// In some cases, implementations may translate this to a Service selector, so this matches the simple
 	// map used for Service selectors instead of the full Kubernetes LabelSelector type.
 	//