diff --git a/charts/external-dns/CHANGELOG.md b/charts/external-dns/CHANGELOG.md index ef77ad7039..c0438990f0 100644 --- a/charts/external-dns/CHANGELOG.md +++ b/charts/external-dns/CHANGELOG.md @@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed - Avoid creating cluster-scoped RBAC for Gateway API sources when running namespaced with `gatewayNamespace` set. Namespace listing permissions are now only added when `gatewayNamespace` is unset. ([#5843](https://github.com/kubernetes-sigs/external-dns/pull/5843)) _@TobyTheHutt_ +- Ensure container arguments are passed in as strings when extraArgs is a map ([#6284](https://github.com/kubernetes-sigs/external-dns/pull/6284)) _@vflaux_ ## [v1.20.0] diff --git a/charts/external-dns/templates/deployment.yaml b/charts/external-dns/templates/deployment.yaml index b213f754fd..64c194f740 100644 --- a/charts/external-dns/templates/deployment.yaml +++ b/charts/external-dns/templates/deployment.yaml @@ -138,13 +138,13 @@ spec: {{- if not (kindIs "invalid" $value) }} {{- if kindIs "slice" $value }} {{- range $value }} - - --{{ $key }}={{ tpl (. | toString) $ }} + - {{ print "--" $key "=" (tpl (. | toString) $) | quote }} {{- end }} {{- else }} - - --{{ $key }}={{ tpl ($value | toString) $ }} + - {{ print "--" $key "=" (tpl ($value | toString) $) | quote }} {{- end }} {{- else }} - - --{{ $key }} + - {{ print "--" $key | quote }} {{- end }} {{- end }} {{- end }} diff --git a/charts/external-dns/tests/deployment-flags_test.yaml b/charts/external-dns/tests/deployment-flags_test.yaml index 5ea1115304..538c0bf8be 100644 --- a/charts/external-dns/tests/deployment-flags_test.yaml +++ b/charts/external-dns/tests/deployment-flags_test.yaml @@ -138,6 +138,7 @@ tests: extraArgC: - valueC-1 - valueC-2 + extraArgD: "valueD: D" asserts: - equal: @@ -155,6 +156,7 @@ tests: - --extraArgB=valueB - --extraArgC=valueC-1 - --extraArgC=valueC-2 + - "--extraArgD=valueD: D" - it: should throw error when txtPrefix and txtSuffix are set