diff --git a/charts/external-dns/CHANGELOG.md b/charts/external-dns/CHANGELOG.md index ef77ad7039..9729f42213 100644 --- a/charts/external-dns/CHANGELOG.md +++ b/charts/external-dns/CHANGELOG.md @@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed - Avoid creating cluster-scoped RBAC for Gateway API sources when running namespaced with `gatewayNamespace` set. Namespace listing permissions are now only added when `gatewayNamespace` is unset. ([#5843](https://github.com/kubernetes-sigs/external-dns/pull/5843)) _@TobyTheHutt_ +- Ensure container arguments are passed in as strings ([#6264](https://github.com/kubernetes-sigs/external-dns/pull/6264)) _@KhooHaoYit_ ## [v1.20.0] diff --git a/charts/external-dns/templates/deployment.yaml b/charts/external-dns/templates/deployment.yaml index b213f754fd..06b3ff1468 100644 --- a/charts/external-dns/templates/deployment.yaml +++ b/charts/external-dns/templates/deployment.yaml @@ -150,7 +150,7 @@ spec: {{- end }} {{- if kindIs "slice" .Values.extraArgs }} {{- range .Values.extraArgs }} - - {{ tpl . $ }} + - {{ tpl . $ | quote }} {{- end }} {{- end }} ports: diff --git a/charts/external-dns/tests/deployment-flags_test.yaml b/charts/external-dns/tests/deployment-flags_test.yaml index 5ea1115304..095883a76d 100644 --- a/charts/external-dns/tests/deployment-flags_test.yaml +++ b/charts/external-dns/tests/deployment-flags_test.yaml @@ -202,3 +202,15 @@ tests: - contains: path: spec.template.spec.containers[?(@.name == "external-dns")].args content: "--source=ingress" + + - it: should format extraArgs as list of strings + set: + provider: + name: cloudflare + extraArgs: + - --cloudflare-dns-records-per-page + - "5000" + asserts: + - contains: + path: spec.template.spec.containers[?(@.name == "external-dns")].args + content: "5000"