Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm test with ct install is installing as CronJob and not Deployment #949

Closed
knelasevero opened this issue Sep 12, 2022 · 3 comments · Fixed by #953
Closed

Helm test with ct install is installing as CronJob and not Deployment #949

knelasevero opened this issue Sep 12, 2022 · 3 comments · Fixed by #953
Assignees

Comments

@knelasevero
Copy link
Contributor

knelasevero commented Sep 12, 2022

While looking at #946 I noticed that in the gh-actions output https://github.com/kubernetes-sigs/descheduler/pull/945/checks ct install is installing descheduler in CronJob mode, which does not get useful events and logs back to us (even though we have helm-extra-set-args: "--set=kind=Deployment" set in https://github.com/kubernetes-sigs/descheduler/blob/master/.github/ci/ct.yaml) .

This worked at some point since we had this during reviews: #895 (review) 🤔

Installing it as Deployment will be better to check info and possibly add subsequent simple tests against that pod.

@a7i
Copy link
Contributor

a7i commented Sep 18, 2022

/assign

@knelasevero would you take a look at #953 and see if it makes sense?

@knelasevero
Copy link
Contributor Author

knelasevero commented Sep 28, 2022

Thanks @a7i ! And sorry for the delay on this one. For some reason I totally missed the notification

@a7i
Copy link
Contributor

a7i commented Sep 28, 2022

No worries @knelasevero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants