We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While looking at #946 I noticed that in the gh-actions output https://github.com/kubernetes-sigs/descheduler/pull/945/checks ct install is installing descheduler in CronJob mode, which does not get useful events and logs back to us (even though we have helm-extra-set-args: "--set=kind=Deployment" set in https://github.com/kubernetes-sigs/descheduler/blob/master/.github/ci/ct.yaml) .
helm-extra-set-args: "--set=kind=Deployment"
This worked at some point since we had this during reviews: #895 (review) 🤔
Installing it as Deployment will be better to check info and possibly add subsequent simple tests against that pod.
The text was updated successfully, but these errors were encountered:
/assign
@knelasevero would you take a look at #953 and see if it makes sense?
Sorry, something went wrong.
Thanks @a7i ! And sorry for the delay on this one. For some reason I totally missed the notification
No worries @knelasevero
a7i
Successfully merging a pull request may close this issue.
While looking at #946 I noticed that in the gh-actions output https://github.com/kubernetes-sigs/descheduler/pull/945/checks ct install is installing descheduler in CronJob mode, which does not get useful events and logs back to us (even though we have
helm-extra-set-args: "--set=kind=Deployment"
set in https://github.com/kubernetes-sigs/descheduler/blob/master/.github/ci/ct.yaml) .This worked at some point since we had this during reviews: #895 (review) 🤔
Installing it as Deployment will be better to check info and possibly add subsequent simple tests against that pod.
The text was updated successfully, but these errors were encountered: