Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider looking up for an ignore list when checking Pod volumes for service-mesh enabled environments #1562

Open
Dentrax opened this issue Nov 28, 2024 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Dentrax
Copy link
Contributor

Dentrax commented Nov 28, 2024

Is your feature request related to a problem? Please describe.
Descheduler doesn't work as expected in a service-meshed (istio) environment due to emptyDir local volumes.

Istio sidecar includes the following volumes:

- emptyDir:
    medium: Memory
  name: istio-envoy
- emptyDir: {}
  name: istio-data

That means, if you are using the Descheduler on a large service-mesh force-enabled clusters, it wouldn't take any effect, due to Pod sidecars that injected on runtime.

Almost all Descheduler instances across all clusters, throws the following error:

Pod fails the following checks" pod="ns/my-pod" checks="pod has local storage and descheduler is not configured with evictLocalStoragePods

Describe the solution you'd like
Pass additional options to IsPodWithLocalStorage for more control on how should behave.

In the configuration, I'd like to pass some ignore list:

  1. to ignore by container name (i.e., istio-proxy)
  2. to ignore by volume name

By doing so, the Descheduler will start work as expected on service-meshed environment.

Describe alternatives you've considered
Set evictLocalStoragePods to true. But its a bit risky to enable this on production because it will entirely ignore the volumes as expected. We'd not want this.

What version of descheduler are you using?

descheduler version: 0.28

Additional context
-

@Dentrax Dentrax added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant