⚠ bump to kubernetes 1.22.1, remove support for legacy v1beta1 CRDs and webhooks #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
camilamacedo86
approved these changes
Sep 17, 2021
There was a problem hiding this comment.
Great work @joelanford 👍
Just checking if we can get merge and do a release :-)
k8s-ci-robot
added
lgtm
camilamacedo86
removed
lgtm
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, camilamacedo86, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-controller-tools-test-master |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
joelanford
force-pushed
the
k8s-1.22
branch
from
2ad3b05
to
09f1952
Compare
k8s-ci-robot
removed
the
lgtm
|
Hi @alvaroaleman, Yes. That fails with the master rebase only. So, that seems that was missing a rebase, Hi @joelanford, Thank you to push the changes. |
|
/hold cancel |
k8s-ci-robot
added
lgtm
1 task
4 tasks
10 tasks
AlexanderYastrebov
added a commit
to AlexanderYastrebov/controller-tools
that referenced
this pull request
Apr 10, 2024
Reinstate crd:preserveUnknownFields option removed by kubernetes-sigs#607 to allow specifying the value of deprecated spec.preserveUnknownFields CRD field. This is useful for updating CRDs that were automatically converted from v1beta1 version which had true as a default value and resulted in: ``` $ kubectl get crd foo.bar -o yaml | grep preserveUnknownFields preserveUnknownFields: true message: 'spec.preserveUnknownFields: Invalid value: true: must be false' ``` Fixes kubernetes-sigs#476
AlexanderYastrebov
added a commit
to AlexanderYastrebov/controller-tools
that referenced
this pull request
Apr 10, 2024
Reinstate crd:preserveUnknownFields option removed by kubernetes-sigs#607 to allow specifying the value of deprecated spec.preserveUnknownFields CRD field. This is useful for updating CRDs that were automatically converted from v1beta1 version which had true as a default value and resulted in: ``` $ kubectl get crd foo.bar -o yaml | grep preserveUnknownFields preserveUnknownFields: true message: 'spec.preserveUnknownFields: Invalid value: true: must be false' ``` For kubernetes-sigs#476
AlexanderYastrebov
added a commit
to AlexanderYastrebov/controller-tools
that referenced
this pull request
Apr 11, 2024
Reinstate crd:preserveUnknownFields option removed by kubernetes-sigs#607 to allow specifying the value of deprecated spec.preserveUnknownFields CRD field. This is useful for updating CRDs that were automatically converted from v1beta1 version which had true as a default value and resulted in: ``` $ kubectl get crd foo.bar -o yaml | grep preserveUnknownFields preserveUnknownFields: true message: 'spec.preserveUnknownFields: Invalid value: true: must be false' ``` For kubernetes-sigs#476
AlexanderYastrebov
added a commit
to AlexanderYastrebov/controller-tools
that referenced
this pull request
Apr 15, 2024
Reinstate crd:preserveUnknownFields option removed by kubernetes-sigs#607 to allow specifying the value of deprecated spec.preserveUnknownFields CRD field. This is useful for updating CRDs that were automatically converted from v1beta1 version which had true as a default value and resulted in: ``` $ kubectl get crd foo.bar -o yaml | grep preserveUnknownFields preserveUnknownFields: true message: 'spec.preserveUnknownFields: Invalid value: true: must be false' ``` For kubernetes-sigs#476
k8s-ci-robot
pushed a commit
that referenced
this pull request
Apr 19, 2024
* crd: allow specifying spec.preserveUnknownFields Reinstate crd:preserveUnknownFields option removed by #607 to allow specifying the value of deprecated spec.preserveUnknownFields CRD field. This is useful for updating CRDs that were automatically converted from v1beta1 version which had true as a default value and resulted in: ``` $ kubectl get crd foo.bar -o yaml | grep preserveUnknownFields preserveUnknownFields: true message: 'spec.preserveUnknownFields: Invalid value: true: must be false' ``` For #476 * crd: rename marker to DeprecatedV1beta1CompatibilityPreserveUnknownFields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps controller-tools k8s dependencies to 1.22.1
This is a breaking change. It removes support for v1beta1 CRDs and webhooks. These APIs are no longer served in 1.22.