Skip to content

✨ Introduce controllerutil.Object interface #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 3 commits into from
May 20, 2020
Merged

✨ Introduce controllerutil.Object interface #898

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
044e189
Introduce KubernetesResource interface
ruromero Apr 14, 2020
1d05f23
Rename and move KubernetesObject
ruromero Apr 20, 2020
ea2e6b1
Rename to Object
ruromero May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/client/interfaces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
apierrors "k8s.io/apimachinery/pkg/api/errors"

"k8s.io/apimachinery/pkg/api/meta"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"
)
Expand Down Expand Up @@ -133,3 +134,10 @@ func IgnoreNotFound(err error) error {
}
return err
}

// KubernetesResource allows functions to work indistinctly with any resource that
// implements both Object interfaces.
type KubernetesResource interface {
Copy link
Member

@joelanford joelanford Apr 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is a union of two *.Object types would it be more intuitive for this to also include Object in the name?

Also, I wonder if the client package is the most appropriate place for this type. Nothing is really jumping out to me as an alternate though. Perhaps pkg/controller/controllerutil? 🤷‍♂️

Copy link
Contributor Author

@ruromero ruromero Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed and moved

metav1.Object
runtime.Object
}