We maintain release tools only under Spec repo #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
xing-yang
reviewed
Oct 23, 2020
Makefile
Outdated
| #!/usr/bin/env bash | ||
|
|
||
| # Copyright 2019 The Kubernetes Authors. | ||
| # Copyright 2017 The Kubernetes Authors. |
There was a problem hiding this comment.
Fixed, thanks for the review.
brahmaroutu
force-pushed
the
remove_release_tools
branch
from
7250328
to
465b16f
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brahmaroutu, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove release-tools from this repo
We will maintain only one release-tools under container-object-storage-interface-spec repo
We will have a build step that will copy release tools to required repo's
We also will maintain COSI release tools which will NOT be part of CSI release tools(no subtrees)