✨Add CAPD webhooks#3088
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom May 26, 2020
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
sedefsavas
force-pushed
the
capd-webhook
branch
4 times, most recently
from
f4c1974 to
5f7d8d7
Compare
Member
fabriziopandini
left a comment
fabriziopandini
left a comment
There was a problem hiding this comment.
@sedefsavas thanks for this PR
main concern is about extra-mount validation, but overall lgtm
test/infrastructure/docker/api/v1alpha3/dockermachinetemplate_webhook.go
Outdated
Show resolved
Hide resolved
test/infrastructure/docker/api/v1alpha3/dockermachinetemplate_webhook.go
Outdated
Show resolved
Hide resolved
Member
|
It seems the new commit requires go fmt |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds validation and defaulting webhooks for CAPD DockerMachineTemplate.
Which issue(s) this PR fixes
Fixes #2949